Bump AGP to `8.5.1` #21082

wzieba · 2024-07-25T15:22:14Z

Description

This PR bumps AGP to 8.5.1 to address security alerts and keep our tooling up to date.

To test

Please smoke-test the app. As library modules in this project didn't have obfuscation config, there shouldn't be any issues in this area.

Dependencies

Avoid duplicated formatting, use String arguments when it's expected

Improve the comment to match javadoc convention

as it's not trivial to address this warning. #21079

Here it's only used for mocking tests, so no if anything, we could address defining flag in `ConnectionStatusLiveData` class. For some reason, lint is not reporting any issues there, so I think it's fine

dangermattic · 2024-07-25T15:24:52Z

	3 Warnings
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2024-07-25T15:41:48Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21082-515198c
	Commit	`515198c`
	Direct Download	`jetpack-prototype-build-pr21082-515198c.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-07-25T15:42:21Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21082-515198c
	Commit	`515198c`
	Direct Download	`wordpress-prototype-build-pr21082-515198c.apk`

Note: Google Login is not supported on these builds.

In these places i18n is not needed - either code value or an empty string

…t of future work

config/lint/baseline.xml

ParaskP7

👋 @wzieba and thanks for this update, it is a ✅ from me, but I first want to discuss all these Lint baseline changes before merging this to trunk, including #21083 and my comment here.

config/lint/baseline.xml

WordPress/src/main/java/org/wordpress/android/ui/reader/views/ReaderExpandableTagsView.kt

This reverts commit 97c5f72, reversing changes made to 336298b.

#21084

#21085

wzieba · 2024-07-29T14:02:17Z

Sorry @ParaskP7 it's not yet ready for re-review, I forgot about last comment 😅

build.gradle

ParaskP7 · 2024-07-29T15:07:32Z

Suggestion (💡): Related to this and this, maybe it is best to redo this PR, cherry-pick all your commits, except for 7dc1e44 and do that again at the very end, making sure it doesn't add any new issue, only updating and removing issues, wdyt? 🤔 😊

PS: I am guessing this previously accompanying PR will/should be soon closed too, right? 🤔

wzieba · 2024-07-29T19:34:47Z

Suggestion (💡): Related to #21082 (comment) and #21082 (comment), maybe it is best to redo this PR, cherry-pick all your commits, except for 7dc1e44 and do that again at the very end, making sure it doesn't add any new issue, only updating and removing issues, wdyt? 🤔 😊

Frankly, I don't see benefits of recreating this PR - the diff is small, and we can easily verify all the changes it'll introduce to the codebase.

wpmobilebot · 2024-07-29T19:38:27Z

Found 1 violations:

The PR caused some dependency changes (expand to see details)

-+--- androidx.databinding:viewbinding:8.1.0
++--- androidx.databinding:viewbinding:8.5.1
 \--- project :libs:image-editor
-     \--- androidx.databinding:viewbinding:8.1.0 (*)
+     \--- androidx.databinding:viewbinding:8.5.1 (*)

Please review and act accordingly

Refreshing baseline file with ``` disable += [ 'KtxExtensionAvailable', 'UsingMaterialAndMaterial3Libraries', 'UnknownNullness', 'MissingNullAnnotationOnField', 'MissingNullAnnotationOnConstructorParameter', 'MissingNullAnnotationOnMethodParameter', 'MissingNullAnnotationOnMethodReturnType', ] ``` temporary setting

As comment says, it's no longer needed with the newest lint shipped with AGP 8.5.1

sonarcloud · 2024-08-06T07:43:52Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-08-06T08:10:39Z

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.71%. Comparing base (2f712d1) to head (515198c).

Files	Patch %	Lines
...ss/android/ui/voicetocontent/WaveformVisualizer.kt	0.00%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #21082   +/-   ##
=======================================
  Coverage   40.71%   40.71%           
=======================================
  Files        1530     1530           
  Lines       70261    70261           
  Branches    11617    11617           
=======================================
  Hits        28606    28606           
  Misses      39070    39070           
  Partials     2585     2585

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wzieba added 5 commits July 24, 2024 20:07

Bump AGP to 8.5.1

c9a9b8a

Address StringFormatMatches lint error

371a4f4

Avoid duplicated formatting, use String arguments when it's expected

Address WrongCommentType

9a28686

Improve the comment to match javadoc convention

Suppress RestrictedApi

e2d6b2d

as it's not trivial to address this warning. #21079

Suppress UnspecifiedRegisterReceiverFlag

ac1890f

Here it's only used for mocking tests, so no if anything, we could address defining flag in `ConnectionStatusLiveData` class. For some reason, lint is not reporting any issues there, so I think it's fine

wzieba added 2 commits July 25, 2024 17:44

Suppress SetTextI18n

336298b

In these places i18n is not needed - either code value or an empty string

Update lint baseline

7dc1e44

wzieba mentioned this pull request Jul 25, 2024

Update lint baseline file #21083

Closed

Merge branch 'update_lint_baseline' into bump_agp_to_8_5_1

97c5f72

wzieba changed the base branch from trunk to update_lint_baseline July 25, 2024 16:34

Update lint baseline with warnings and errors that should be a subjec…

63e3683

…t of future work

This was referenced Jul 25, 2024

Address UnsafeImplicitIntentLaunch lint error #21085

Open

Consider dropping android:screenOrientation parameter #21084

Open

wzieba commented Jul 25, 2024

View reviewed changes

config/lint/baseline.xml Outdated Show resolved Hide resolved

wzieba commented Jul 25, 2024

View reviewed changes

config/lint/baseline.xml Outdated Show resolved Hide resolved

wzieba added Tech Debt Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging labels Jul 26, 2024

wzieba added this to the 25.5 milestone Jul 26, 2024

wzieba changed the title ~~[WIP] Bump AGP to 8.5.1~~ Bump AGP to 8.5.1 Jul 26, 2024

wzieba mentioned this pull request Jul 26, 2024

Bump AGP to 8.5.1 woocommerce/woocommerce-android#12042

Merged

1 task

wzieba requested a review from ParaskP7 July 26, 2024 10:54

wzieba marked this pull request as ready for review July 26, 2024 10:54

This was referenced Jul 26, 2024

Bump AGP to 8.5.1 wordpress-mobile/WordPress-FluxC-Android#3065

Merged

Bump AGP to 8.5.1 WordPress/gutenberg#64044

Merged

ParaskP7 reviewed Jul 29, 2024

View reviewed changes

config/lint/baseline.xml Outdated Show resolved Hide resolved

WordPress/src/main/java/org/wordpress/android/ui/reader/views/ReaderExpandableTagsView.kt Show resolved Hide resolved

Revert "Merge branch 'update_lint_baseline' into bump_agp_to_8_5_1"

1619fd6

This reverts commit 97c5f72, reversing changes made to 336298b.

wzieba changed the base branch from update_lint_baseline to trunk July 29, 2024 12:29

wzieba added 3 commits July 29, 2024 14:30

Merge branch 'trunk' into bump_agp_to_8_5_1

04e663d

Suppress DiscouragedApi on android:screenOrientation

d079a87

#21084

Suppress UnsafeImplicitIntentLaunch

28db317

#21085

wzieba requested a review from ParaskP7 July 29, 2024 14:01

wzieba removed the request for review from ParaskP7 July 29, 2024 14:02

Avoid duplicated String formatting

7e9ba6c

wzieba requested a review from ParaskP7 July 29, 2024 14:11

ParaskP7 reviewed Jul 29, 2024

View reviewed changes

build.gradle Outdated Show resolved Hide resolved

Revert side-effect changes introduced in 1619fd6

137521b

wzieba requested a review from ParaskP7 July 29, 2024 19:35

wzieba added 2 commits July 30, 2024 15:56

Address AutoboxingStateCreation warning

44fe9d6

ParaskP7 approved these changes Jul 30, 2024

View reviewed changes

Remove setting ObsoleteLintCustomCheck as warning

01d64f2

As comment says, it's no longer needed with the newest lint shipped with AGP 8.5.1

wzieba modified the milestones: 25.5, 25.6 Aug 1, 2024

mokagio removed this from the 25.6 milestone Aug 2, 2024

Merge branch 'trunk' into bump_agp_to_8_5_1

515198c

wzieba removed the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Aug 6, 2024

wzieba merged commit 8fc19bf into trunk Aug 6, 2024
21 checks passed

wzieba deleted the bump_agp_to_8_5_1 branch August 6, 2024 09:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump AGP to `8.5.1` #21082

Bump AGP to `8.5.1` #21082

wzieba commented Jul 25, 2024 •

edited

Loading

dangermattic commented Jul 25, 2024 •

edited

Loading

wpmobilebot commented Jul 25, 2024 •

edited

Loading

wpmobilebot commented Jul 25, 2024 •

edited

Loading

ParaskP7 left a comment

wzieba commented Jul 29, 2024 •

edited

Loading

ParaskP7 commented Jul 29, 2024 •

edited

Loading

wzieba commented Jul 29, 2024 •

edited

Loading

wpmobilebot commented Jul 29, 2024

sonarcloud bot commented Aug 6, 2024

codecov bot commented Aug 6, 2024

Bump AGP to 8.5.1 #21082

Bump AGP to 8.5.1 #21082

Conversation

wzieba commented Jul 25, 2024 • edited Loading

Description

To test

Dependencies

dangermattic commented Jul 25, 2024 • edited Loading

wpmobilebot commented Jul 25, 2024 • edited Loading

wpmobilebot commented Jul 25, 2024 • edited Loading

ParaskP7 left a comment

Choose a reason for hiding this comment

wzieba commented Jul 29, 2024 • edited Loading

ParaskP7 commented Jul 29, 2024 • edited Loading

wzieba commented Jul 29, 2024 • edited Loading

wpmobilebot commented Jul 29, 2024

sonarcloud bot commented Aug 6, 2024

Quality Gate passed

codecov bot commented Aug 6, 2024

Codecov Report

Bump AGP to `8.5.1` #21082

Bump AGP to `8.5.1` #21082

wzieba commented Jul 25, 2024 •

edited

Loading

dangermattic commented Jul 25, 2024 •

edited

Loading

wpmobilebot commented Jul 25, 2024 •

edited

Loading

wpmobilebot commented Jul 25, 2024 •

edited

Loading

wzieba commented Jul 29, 2024 •

edited

Loading

ParaskP7 commented Jul 29, 2024 •

edited

Loading

wzieba commented Jul 29, 2024 •

edited

Loading