-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump AGP to 8.5.1
#64044
Bump AGP to 8.5.1
#64044
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @wzieba! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
952906d
to
2b03954
Compare
2b03954
to
7c96736
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
What?
Bump Android Gradle Plugin used by react-native-bridge/android to version 8.5.1
Why?
8.5.1
wordpress-mobile/WordPress-Android#21082)How?
Bump version in
settings.gradle
Testing Instructions
8.5.1
wordpress-mobile/WordPress-Android#210828.5.1
wordpress-mobile/gutenberg-mobile#7010Perform both tests in
release
variant.Comment
AGP in version
8.4.0
brings changes to how libraries are obfuscated. I don't suspect any issues here as it's a standalone SDK (not a library module) andenableProguardInReleaseBuilds
value is set tofalse
. Anyway, it's good to double-check this.Testing Instructions for Keyboard
Screenshots or screencast