Removes - unused methods and classess using Android Studio Tool - Part 2

[AjeshRPai]

Fixes #

Description

This PR removes unused code from the Repo using Android Tool. Code → Analyze → Run inspection by name..., type Unused declaration

2nd Part of #19788

To Test:

1. Smoke test the JP And WP app and verify that everything is working as expected
2. Verify that the classess, methods and files deleted are unused.

Regression Notes

1. Potential unintended areas of impact
   App is not working as expected

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manual testing and Smoke testing

3. What automated tests I added (or what prevented me from doing so)
   Nothing

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19850-9658b98
	Commit	9658b98
	Direct Download	wordpress-prototype-build-pr19850-9658b98.apk

Note: Google Login is not supported on these builds.

[irfano]

I found out some unused fields while reviewing. Then I noticed this PR only covers methods and classes and I refrained from delving into the details to find more unused fields.
When I run unused declaration for only methods and classes, there are still 317 warnings. Some of these warnings are false alarms, but others are really unused. Did you intentionally leave them in the code? Here are few examples:

• AztecEditorFragment.canUndo()
• AztecEditorFragment.MediaPredicate.getTempMediaIdPredicate()
• AppPrefs.getReaderRecommendedTagsDeletedForLoggedOutUser()
• LocaleManager.createLanguageDetailDisplayStrings()

Was your intention to remove all unused methods and classes? If that is the case, I can go over all warnings to find unused declarations that are really unused.
I have smoke-tested the basic features, and they are still working properly 🟢. I believe this PR is safe. We can either add more unused code and merge this, or merge this and perform other cleanups in a separate PR.

[irfano]

We can remove also AnalyticsUtil.NEWS_CARD_ORIGIN and AnalyticsUtil.NEWS_CARD_VERSION.

[irfano]

We can also remove the definition of these keys, DeletablePrefKey.STATS_WIDGET_KEYS_BLOGS, DeletablePrefKey.STATS_WIDGET_DATA, DeletablePrefKey.STATS_WIDGET_DATA, DeletablePrefKey.STATS_WIDGET_PROMO_ANALYTICS, UndeletablePrefKey.IAP_SYNC_REQUIRED, DeletablePrefKey.PENDING_DRAFTS_NOTIFICATION_LAST_NOTIFICATION_DATES.

[peril-wordpress-mobile]

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

[wpmobilebot]

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[AjeshRPai]

Hey @irfano

Thanks for the review. 🙌🏼

When I run unused declaration for only methods and classes, there are still 317 warnings. Some of these warnings are false alarms, but others are unused. Did you intentionally leave them in the code? Here are a few examples

I reverted some commits, which deleted the unused functions in the Editor libs. I intend to take it up removing of the unused methods from Editor libs in a separate PR.

Was your intention to remove all unused methods and classes? If that is the case, I can go over all warnings to find unused declarations that are really unused.

Yup, I was concentrating more on Classes and Methods. There is a chance that I might have missed some methods or classes. If you can, go over all the warnings that are still there. It would be really helpful. I suggest you do it in a separate PR if possible. Otherwise, I can take it up and create a Part 3 PR.

[irfano]

We discussed with Ajesh and decided to continue removing the remaining warnings in other PRs.
The changes in this PR LGTM! 👍🏻 Merging now.