-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes: un-used resources using the Android studio tool 1/2 #19788
Conversation
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AjeshRPai - I spent a good hour going through the features. I feel that I can approve this change; however I would love it if someone can give it a whirl as it's such a big change and no real testing steps. 👍
Hey @irfano @ravishanker Since you left a 👍🏼 in the Slack message, I assume you both want to review the PR. Hence, I am adding both of you as reviewers. I am waiting for one more approval to merge this PR. So feel free to ignore this PR if there is two approval. Thank you in advance for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested basic features manually. LGTM! 👍🏻 Thanks for taking care of this.
Generated by 🚫 Danger |
Fixes #
Description
This PR deletes the unused resources in the code using Remove Unused Resources tool in the Android Studio
To Test:
Regression Notes
Potential unintended areas of impact
App is not working as expected
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and Smoke testing
What automated tests I added (or what prevented me from doing so)
Nothing
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: