Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes: un-used resources using the Android studio tool 1/2 #19788

Merged
merged 15 commits into from
Dec 20, 2023

Conversation

AjeshRPai
Copy link
Contributor

@AjeshRPai AjeshRPai commented Dec 14, 2023

Fixes #

Description

This PR deletes the unused resources in the code using Remove Unused Resources tool in the Android Studio

To Test:

  1. Smoke test the JP And WP app and verify that everything is working as expected
  2. Verify that the classess, resources and files deleted are unused.

Regression Notes

  1. Potential unintended areas of impact
    App is not working as expected

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing and Smoke testing

  3. What automated tests I added (or what prevented me from doing so)
    Nothing

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@AjeshRPai AjeshRPai added this to the 24.0 milestone Dec 14, 2023
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 14, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19788-fcc6fc3
Commitfcc6fc3
Direct Downloadwordpress-prototype-build-pr19788-fcc6fc3.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 14, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19788-fcc6fc3
Commitfcc6fc3
Direct Downloadjetpack-prototype-build-pr19788-fcc6fc3.apk
Note: Google Login is not supported on these builds.

@AjeshRPai AjeshRPai requested a review from zwarm December 14, 2023 13:13
@AjeshRPai AjeshRPai marked this pull request as ready for review December 14, 2023 13:13
@AjeshRPai AjeshRPai requested a review from a team as a code owner December 14, 2023 14:20
@zwarm zwarm self-assigned this Dec 14, 2023
@AjeshRPai AjeshRPai added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Dec 14, 2023
Copy link
Contributor

@zwarm zwarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AjeshRPai - I spent a good hour going through the features. I feel that I can approve this change; however I would love it if someone can give it a whirl as it's such a big change and no real testing steps. 👍

@AjeshRPai
Copy link
Contributor Author

AjeshRPai commented Dec 15, 2023

Thanks @zwarm for the review. 🙌🏼 . You are right. I will wait until some one else also takes a look at it and gives me a 👍🏼 to merge.

Also, I came across one more class after your review which seems to be unused. See the commit 5b177d5

Feel free to re-review if you think its necessary.

@AjeshRPai AjeshRPai removed the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Dec 15, 2023
@AjeshRPai
Copy link
Contributor Author

Hey @irfano @ravishanker

Since you left a 👍🏼 in the Slack message, I assume you both want to review the PR. Hence, I am adding both of you as reviewers.

I am waiting for one more approval to merge this PR. So feel free to ignore this PR if there is two approval.

Thank you in advance for the review.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested basic features manually. LGTM! 👍🏻 Thanks for taking care of this.

@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@AjeshRPai AjeshRPai merged commit 5f8ff31 into trunk Dec 20, 2023
20 checks passed
@AjeshRPai AjeshRPai deleted the issue-removes-un-used-resources branch December 20, 2023 09:38
@AjeshRPai AjeshRPai changed the title Removes: un-used resources using the Android studio tool Removes: un-used resources using the Android studio tool 1/2 Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants