Adds XMLRPCRequest missing accept header #19683

antonis · 2023-11-28T14:05:49Z

Depends on: wordpress-mobile/WordPress-FluxC-Android#2911

Description

This PR adds the Accept: */* header to all XMLRPC Requests and aligns with the behaviour of the iOS app #7846 (comment)

To Test:

Follow the steps in wordpress-mobile/WordPress-FluxC-Android#2911

Regression Notes

Potential unintended areas of impact
- Self-hosted sites
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing
What automated tests I added (or what prevented me from doing so)
- This was a network layer change

PR Submission Checklist:

I have completed the Regression Notes.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

Portrait and landscape orientations.
Light and dark modes.
Fonts: Larger, smaller and bold text.
High contrast.
Talkback.
Languages with large words or with letters/accents not frequently used in English.
Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
Large and small screen sizes. (Tablet and smaller phones)
Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

wpmobilebot · 2023-11-28T14:14:35Z

Found 1 violations:

The PR caused the following dependency changes:

-+--- org.wordpress:fluxc:{strictly 2.57.0} -> 2.57.0
-|    +--- org.wordpress:wellsql:2.0.0
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:2.57.0
-|    +--- org.greenrobot:eventbus:3.3.1
-|    |    \--- org.greenrobot:eventbus-java:3.3.1
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.11.0 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.1
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.6.2 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.6.2 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
-|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.20 -> 1.9.10 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
-|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6 (*)
-|    +--- androidx.security:security-crypto:1.0.0
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|    |    \--- com.google.crypto.tink:tink-android:1.5.0
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
-|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-|    +--- org.apache.commons:commons-text:1.10.0
-|    |    \--- org.apache.commons:commons-lang3:3.12.0
-|    +--- androidx.room:room-runtime:2.4.2 -> 2.5.0
-|    |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.1 -> 2.2.0 (*)
-|    |    +--- androidx.room:room-common:2.5.0
-|    |    |    +--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 -> 1.9.10 (*)
-|    |    +--- androidx.sqlite:sqlite:2.3.0
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.10 (*)
-|    |    \--- androidx.sqlite:sqlite-framework:2.3.0
-|    |         +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |         +--- androidx.sqlite:sqlite:2.3.0 (*)
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.10 (*)
-|    +--- androidx.room:room-ktx:2.4.2
-|    |    +--- androidx.room:room-common:2.4.2 -> 2.5.0 (*)
-|    |    +--- androidx.room:room-runtime:2.4.2 -> 2.5.0 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.10 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.7.3 (*)
-|    +--- com.google.dagger:dagger:2.42 -> 2.46.1
-|    |    \--- javax.inject:javax.inject:1
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.7.3 (*)
++--- org.wordpress:fluxc:{strictly 2911-115f8b738d8aa5c3cca37a5feae24aa7f0e399ff} -> 2911-115f8b738d8aa5c3cca37a5feae24aa7f0e399ff
+|    +--- org.wordpress:wellsql:2.0.0
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:2911-115f8b738d8aa5c3cca37a5feae24aa7f0e399ff
+|    +--- org.greenrobot:eventbus:3.3.1
+|    |    \--- org.greenrobot:eventbus-java:3.3.1
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.11.0 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.1
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.6.2 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.6.2 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.20 -> 1.9.10 (*)
+|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
+|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6 (*)
+|    +--- androidx.security:security-crypto:1.0.0
+|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+|    |    \--- com.google.crypto.tink:tink-android:1.5.0
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
+|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+|    +--- org.apache.commons:commons-text:1.10.0
+|    |    \--- org.apache.commons:commons-lang3:3.12.0
+|    +--- androidx.room:room-runtime:2.4.2 -> 2.5.0
+|    |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.1 -> 2.2.0 (*)
+|    |    +--- androidx.room:room-common:2.5.0
+|    |    |    +--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 -> 1.9.10 (*)
+|    |    +--- androidx.sqlite:sqlite:2.3.0
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.10 (*)
+|    |    \--- androidx.sqlite:sqlite-framework:2.3.0
+|    |         +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|    |         +--- androidx.sqlite:sqlite:2.3.0 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.10 (*)
+|    +--- androidx.room:room-ktx:2.4.2
+|    |    +--- androidx.room:room-common:2.4.2 -> 2.5.0 (*)
+|    |    +--- androidx.room:room-runtime:2.4.2 -> 2.5.0 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.9.10 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.7.3 (*)
+|    +--- com.google.dagger:dagger:2.42 -> 2.46.1
+|    |    \--- javax.inject:javax.inject:1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.7.3 (*)
 \--- org.wordpress:login:1.10.0
-     \--- org.wordpress:fluxc:2.57.0 (*)
+     \--- org.wordpress:fluxc:2.57.0 -> 2911-115f8b738d8aa5c3cca37a5feae24aa7f0e399ff (*)

Please review and act accordingly

wpmobilebot · 2023-11-28T14:26:43Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19683-71a8454
	Commit	`71a8454`
	Direct Download	`wordpress-prototype-build-pr19683-71a8454.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2023-11-28T14:28:06Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr19683-71a8454
	Commit	`71a8454`
	Direct Download	`jetpack-prototype-build-pr19683-71a8454.apk`

Note: Google Login is not supported on these builds.

justtwago

Tested it on a Jurassic Ninja-based self-hosted site and it works as expected: I can see the accept: / header. 🚀

oguzkocer · 2023-11-30T03:28:52Z

build.gradle

@@ -22,7 +22,7 @@ ext {
    automatticTracksVersion = '3.3.0'
    gutenbergMobileVersion = 'v1.109.0'
    wordPressAztecVersion = 'v1.8.0'
-    wordPressFluxCVersion = '2.57.0'
+    wordPressFluxCVersion = '2911-115f8b738d8aa5c3cca37a5feae24aa7f0e399ff'


@antonis @justtwago Just to remind, we should only merge a proper release or a trunk-{commit_sha} version of our dependencies to trunk. It's fine to use the {pr_number}-{commit_sha} dependencies for testing, but they should not be merged.

Sorry for this @oguzkocer 😅
I opened a small PR to update the reference #19700

No problem 👍 I am going to have to update it again while merging release/23.8 to trunk which is how I noticed it in the first place 😅 So, I've approved the PR and merged it to avoid further conflicts. Hope that's OK!

Updates FluxC version

71a8454

antonis added [Type] Bug Posting/Editing Media Self-hosted labels Nov 28, 2023

antonis added this to the 23.9 milestone Nov 28, 2023

antonis mentioned this pull request Nov 28, 2023

Adds XMLRPCRequest missing accept header wordpress-mobile/WordPress-FluxC-Android#2911

Merged

antonis marked this pull request as ready for review November 28, 2023 14:10

antonis requested review from mkevins and justtwago November 28, 2023 14:10

justtwago approved these changes Nov 29, 2023

View reviewed changes

justtwago merged commit bb19b2b into trunk Nov 29, 2023
20 checks passed

justtwago deleted the fix/7846-adds-xmlrpc-accept-header branch November 29, 2023 17:34

oguzkocer reviewed Nov 30, 2023

View reviewed changes

antonis mentioned this pull request Nov 30, 2023

Updates FluxC reference to point to trunk #19700

Merged

12 tasks

justtwago mentioned this pull request Dec 7, 2023

[Gutenberg] - Filter media types when sharing files to the app #19754

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds XMLRPCRequest missing accept header #19683

Adds XMLRPCRequest missing accept header #19683

antonis commented Nov 28, 2023 •

edited

Loading

wpmobilebot commented Nov 28, 2023

wpmobilebot commented Nov 28, 2023

wpmobilebot commented Nov 28, 2023

justtwago left a comment

oguzkocer Nov 30, 2023

antonis Nov 30, 2023

oguzkocer Nov 30, 2023

Adds XMLRPCRequest missing accept header #19683

Adds XMLRPCRequest missing accept header #19683

Conversation

antonis commented Nov 28, 2023 • edited Loading

Description

To Test:

Regression Notes

PR Submission Checklist:

UI Changes Testing Checklist:

wpmobilebot commented Nov 28, 2023

The PR caused the following dependency changes:

wpmobilebot commented Nov 28, 2023

wpmobilebot commented Nov 28, 2023

justtwago left a comment

Choose a reason for hiding this comment

oguzkocer Nov 30, 2023

Choose a reason for hiding this comment

antonis Nov 30, 2023

Choose a reason for hiding this comment

oguzkocer Nov 30, 2023

Choose a reason for hiding this comment

antonis commented Nov 28, 2023 •

edited

Loading