-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] - Filter media types when sharing files to the app #19754
Conversation
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this @geriux! Awesome work! The code looks simple and good for me 👍 I tested the change on Google Pixel 7 Pro (Android 14) and it behaved as described - no crash when selecting unsupported files to share as a new post.
I'm not sure if we can merge not stable Gutenberg version though:
gutenbergMobileVersion = '6444-7b344ab956224ba96726111c150dc44a39be8b9e'
Reference: #19683 (comment)
Thank you for testing, @justtwago and good call out on noting the Gutenberg ref. Typically for Gutenberg PRs on WPAndroid we update the Gutenberg reference to a specific Gutenberg Mobile branch and commit to generate the CI builds. Once we merge the Gutenberg and Gutenberg Mobile PRs, we'll update the WPAndroid Gutenberg reference back to the latest Gutenberg Mobile tag before merging this PR. Here's an example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding another +1 that I was able to successfully test the changes via WordPress/gutenberg#56791 (review) 🚀
Cool, thank you a lot for clarifying this, @derekblank! 💯 Totally makes sense. |
Thank you both for reviewing and testing! For this case, since these changes don't rely on the Gutenberg ones, I will revert updating the Gutenberg reference since it was just for testing the latest changes and we can update it later on either with the next release or alpha version. |
029b694
to
c5f7c68
Compare
Fixes wordpress-mobile/gutenberg-mobile#6443
Related PRs:
This PR fixes an issue when appending unsupported media types when using the Sharing functionality on Android devices.
The only way to be able to "Share" unsupported media types is when multi-selecting files that the app does support like images or videos.
For more information please check Gutenberg's PR description.
To Test:
PDF
,jpg
, andmp4
.TestCase1.mov
TestCase2.mov
Regression Notes
It should only affect the editor.
Manual tests.
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: