-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Modernization Posts: Update post list layout #19425
Merged
zwarm
merged 41 commits into
feature/ui-modernization-posts-and-pages
from
issue/19341-update-post-list-layout
Oct 25, 2023
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
039a161
Add more vertical icon
zwarm 7b173b2
Refactor: update post list and post list skeleton layouts
zwarm fac920f
Add dimens and styles for the updated post list and post list skeleto…
zwarm 82c374e
Refactor: streamline the loadingViewHolder because buttons no longer …
zwarm a871efd
Refactor: adjustments for new post list item layout. Removes buttons
zwarm 2a202de
Refactor: set feature image to 48dp
zwarm 47e781c
Refactor: repalce WPTextView with TextView
zwarm e6ffad2
Add string resource for post list edited
zwarm 266c831
Add PostInfo class and use that as the type of postInfo in PostListIt…
zwarm a2c485b
Refactor: build the postInfo using PostInfo. Make info labels part of…
zwarm b7dbc52
Refactor: implement the post info logic for showing the info label in…
zwarm e1e091d
Refactor: implement the title-excerpt rules
zwarm f3cc3c0
Remove options from loadingItems and remove the objects
zwarm 856ba3d
Refactor: remove check for postListType from transformToPostListItemType
zwarm 2ed67a3
Refactor: reuse compactActions for moreActions
zwarm 91990af
Refactor: repurpose createCompactViewActions for more actions
zwarm 79f263c
Refactor: repurpose createCompactViewActions for more actions
zwarm 4e2de35
Refactor: pass isFilteringByAuthorSupported along to determine if the…
zwarm 550d528
Refactor: round the corners of the image
zwarm e2f0e15
Update tests
zwarm 7534549
Remove unused resource
zwarm 3c4731b
Hide/show author filter on search expand/collapse
zwarm a7718af
Increase the featured image size
zwarm 5daf137
Merge branch 'issue/19341-post-list-compact-layout' into issue/19341-…
zwarm 5edcb37
Refactor: when search, move private and pending statuses out of highl…
zwarm 0b31243
Refactor: ensure edited shows when on draft tab while not in serach mode
zwarm 35eccd8
Refactor: replace deprecated layout_constraintWidth_default="wrap" wi…
zwarm 12564bd
Refactor: Remove PostInfo class and revert back to info labels on the…
zwarm b72af97
Refactor: address detekt issues
zwarm 4aa7a0a
Refactor: remove unused imports
zwarm 8817a50
Merge branch 'issue/19341-post-list-compact-layout' into issue/19341-…
zwarm d9ce748
Merge branch 'issue/19341-post-list-compact-layout' into issue/19341-…
zwarm ed8b4a6
Refactor: excerpt should only present the chunk of text that comes be…
zwarm 8f400d2
Refactor: Set start/end margins to 16dp
zwarm 003c3d3
Refactor: Increase the horizontal padding between the text and the im…
zwarm e9e802f
Refactor: Move label before date when in search mode
zwarm fbdfb46
Refactor: Set top and bottom spacing to 8dp instead of 12dp
zwarm 5db8f9a
Refactor: adjust the number of lines are shown for title and excerpt
zwarm a43d17a
Refactor: update test to reflect status shown before date
zwarm 64f3c09
Refactor: address detekt magic number
zwarm 05fa030
Refactor: always show some part of the excerpt if it exists
zwarm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <vector | ||
| xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:autoMirrored="true" | ||
| android:height="24dp" | ||
| android:viewportHeight="24" | ||
| android:viewportWidth="24" | ||
| android:width="24dp" > | ||
|
|
||
| <path | ||
| android:fillColor="?attr/colorOnSurface" | ||
| android:pathData="M13,13V11H11V13H13ZM13,19V17H11V19H13ZM11,7H13V5H11V7Z"/> | ||
| </vector> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @zwarm
Can we re-use the more icon from dashboard or someother place instead of adding a new one?
File:
ic_more_vert_white_24dp?I think the existing usage is by setting the icon and then applying a tint at the usage but may be we can set the color of the more icon to "?attr/colorOnSurface" at all places or use the
ic_more_vert_white_24dpand set a tint inpost_list_itemThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @AjeshRPai - I started in that direction, but then I pulled the svg from the GB icon set and they are different. A future PR will be changing the name of that icon to use the following pattern: "gb_ic_iconname".