Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Modernization Posts: Update post list layout #19425

Merged
merged 41 commits into from
Oct 25, 2023
Merged

UI Modernization Posts: Update post list layout #19425

Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
039a161
Add more vertical icon
zwarm Oct 22, 2023
7b173b2
Refactor: update post list and post list skeleton layouts
zwarm Oct 22, 2023
fac920f
Add dimens and styles for the updated post list and post list skeleto…
zwarm Oct 22, 2023
82c374e
Refactor: streamline the loadingViewHolder because buttons no longer …
zwarm Oct 22, 2023
a871efd
Refactor: adjustments for new post list item layout. Removes buttons
zwarm Oct 22, 2023
2a202de
Refactor: set feature image to 48dp
zwarm Oct 22, 2023
47e781c
Refactor: repalce WPTextView with TextView
zwarm Oct 22, 2023
e6ffad2
Add string resource for post list edited
zwarm Oct 22, 2023
266c831
Add PostInfo class and use that as the type of postInfo in PostListIt…
zwarm Oct 22, 2023
a2c485b
Refactor: build the postInfo using PostInfo. Make info labels part of…
zwarm Oct 22, 2023
b7dbc52
Refactor: implement the post info logic for showing the info label in…
zwarm Oct 22, 2023
e1e091d
Refactor: implement the title-excerpt rules
zwarm Oct 22, 2023
f3cc3c0
Remove options from loadingItems and remove the objects
zwarm Oct 22, 2023
856ba3d
Refactor: remove check for postListType from transformToPostListItemType
zwarm Oct 22, 2023
2ed67a3
Refactor: reuse compactActions for moreActions
zwarm Oct 22, 2023
91990af
Refactor: repurpose createCompactViewActions for more actions
zwarm Oct 22, 2023
79f263c
Refactor: repurpose createCompactViewActions for more actions
zwarm Oct 22, 2023
4e2de35
Refactor: pass isFilteringByAuthorSupported along to determine if the…
zwarm Oct 22, 2023
550d528
Refactor: round the corners of the image
zwarm Oct 22, 2023
e2f0e15
Update tests
zwarm Oct 22, 2023
7534549
Remove unused resource
zwarm Oct 22, 2023
3c4731b
Hide/show author filter on search expand/collapse
zwarm Oct 22, 2023
a7718af
Increase the featured image size
zwarm Oct 22, 2023
5daf137
Merge branch 'issue/19341-post-list-compact-layout' into issue/19341-…
zwarm Oct 22, 2023
5edcb37
Refactor: when search, move private and pending statuses out of highl…
zwarm Oct 23, 2023
0b31243
Refactor: ensure edited shows when on draft tab while not in serach mode
zwarm Oct 23, 2023
35eccd8
Refactor: replace deprecated layout_constraintWidth_default="wrap" wi…
zwarm Oct 23, 2023
12564bd
Refactor: Remove PostInfo class and revert back to info labels on the…
zwarm Oct 23, 2023
b72af97
Refactor: address detekt issues
zwarm Oct 23, 2023
4aa7a0a
Refactor: remove unused imports
zwarm Oct 23, 2023
8817a50
Merge branch 'issue/19341-post-list-compact-layout' into issue/19341-…
zwarm Oct 23, 2023
d9ce748
Merge branch 'issue/19341-post-list-compact-layout' into issue/19341-…
zwarm Oct 23, 2023
ed8b4a6
Refactor: excerpt should only present the chunk of text that comes be…
zwarm Oct 24, 2023
8f400d2
Refactor: Set start/end margins to 16dp
zwarm Oct 24, 2023
003c3d3
Refactor: Increase the horizontal padding between the text and the im…
zwarm Oct 24, 2023
e9e802f
Refactor: Move label before date when in search mode
zwarm Oct 24, 2023
fbdfb46
Refactor: Set top and bottom spacing to 8dp instead of 12dp
zwarm Oct 24, 2023
5db8f9a
Refactor: adjust the number of lines are shown for title and excerpt
zwarm Oct 24, 2023
a43d17a
Refactor: update test to reflect status shown before date
zwarm Oct 24, 2023
64f3c09
Refactor: address detekt magic number
zwarm Oct 24, 2023
05fa030
Refactor: always show some part of the excerpt if it exists
zwarm Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor: Set start/end margins to 16dp
  • Loading branch information
@zwarm
zwarm committed Oct 24, 2023
commit 8f400d21ebeccb483eb289ab788eaed00de380a6
4 changes: 3 additions & 1 deletion WordPress/src/main/res/layout/post_list_item_skeleton.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
<androidx.constraintlayout.widget.ConstraintLayout
android:id="@+id/skeleton_container"
android:layout_width="match_parent"
android:layout_height="wrap_content">
android:layout_height="wrap_content"
android:layout_marginStart="@dimen/margin_extra_large"
android:layout_marginEnd="@dimen/margin_extra_large">

<View
android:id="@+id/skeleton_post_info"
Expand Down