[Tool] Configure Dependabot to Ignore ExoPlayer Dependency
#19206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping '2.13.3' to the newest version requires lots of changes, including changes to Gutenberg. As such, and as agreed, any update is paused. For more info see: https://github.com/wordpress-mobile/ WordPress-Android/pull/17936#issuecomment-1553227875
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19206-12dca79 | |
| Commit | 12dca79 | |
| Direct Download | wordpress-prototype-build-pr19206-12dca79.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19206-12dca79 | |
| Commit | 12dca79 | |
| Direct Download | jetpack-prototype-build-pr19206-12dca79.apk |
|
👋 @ravishanker , just a friendly ping here, just in case you missed that, it is a very simple, a 1' min PR at most... 😊 🏓 😊 |
ParaskP7
requested review from
thomashorta
and removed request for
ravishanker
|
👋 @ravishanker I've now unassigned you from this and assigned @thomashorta instead. It seems that you might be busy atm and I don't want to hold this PR any longer. 🙏 |
thomashorta
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Thanks for the PR @ParaskP7 🙇🏼 This looks good to me and it makes sense to disable this dependency update for now.
|
Thank you so much for the blazingly fast review and merge @thomashorta , you are the best! 🙇 ❤️ 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables
Dependabotalerts for theExoPlayerdependency. Bumping2.13.3to the newest version requires lots of changes, including changes to Gutenberg. As such, and as agreed, any update is paused.For more info see: #17936 (comment)
To test:
No need to explicitly test this change (like done here and here), verifying that no such
DependabotPR will end-up being opened in the future would be enough for now.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: