Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tool] Configure Dependabot to Ignore AGP Plugins #18335

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

ParaskP7
Copy link
Contributor

This PR disables Dependabot alerts for AGP plugins. As cited from the code comments, the Android Gradle Plugin is a dependency that needs to be in sync with other in-house libraries due to compatibility with composite build.

PS: This configuration update was already done on WCAndroid, and as such, this commit just replicates the same configuration. @wzieba I added you as the reviewer here as it would be super-quick for you to verify that change on WPAndroid too, many thanks in advance. 😊


To test:

See testing instructions on WCAndroid PR here. Verifying that this indeed worked on WCAndroid (its fork) should be enough, no need for extra testing instructions on WPAndroid.


Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To test section above.
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

The Android Gradle Plugin is a dependency that needs to be in sync with
other in-house libraries due to compatibility with composite build.

PS: This configuration update was already done on WCAndroid, and as
such, this commit just replicates the same configuration, see below:

woocommerce/woocommerce-android#8906
@ParaskP7 ParaskP7 added this to the Future milestone Apr 28, 2023
@ParaskP7 ParaskP7 requested review from wzieba and a team April 28, 2023 08:43
@ParaskP7 ParaskP7 self-assigned this Apr 28, 2023
Copy link
Contributor

@wzieba wzieba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18335-9cecc56
Commit9cecc56
Direct Downloadwordpress-prototype-build-pr18335-9cecc56.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18335-9cecc56
Commit9cecc56
Direct Downloadjetpack-prototype-build-pr18335-9cecc56.apk
Note: Google Login is not supported on these builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants