Skip to content

[Dependency Updates] Update navigationVersion to 2.5.3 #18554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 12, 2023
Merged

[Dependency Updates] Update navigationVersion to 2.5.3 #18554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9727f4
Build: Rename nav component to navigation version
ParaskP7 May 30, 2023
adb6ea9
Build: Move navigation below the agp version and plugin ids
ParaskP7 May 30, 2023
661c5c4
Deps: Extract google services plugin related version
ParaskP7 May 30, 2023
9e4e635
Deps: Extract sentry plugin related version
ParaskP7 May 30, 2023
a5aa51c
Deps: Extract violation comments plugin related version
ParaskP7 May 30, 2023
cfe9456
Deps: Update navigation to 2.5.3
ParaskP7 May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/image-editor/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ dependencies {
implementation "androidx.constraintlayout:constraintlayout:$androidxConstraintlayoutVersion"
implementation "androidx.viewpager2:viewpager2:$androidxViewpager2Version"
implementation "com.google.android.material:material:$googleMaterialVersion"
implementation "androidx.navigation:navigation-fragment:$gradle.ext.navComponentVersion"
implementation "androidx.navigation:navigation-ui:$gradle.ext.navComponentVersion"
implementation "androidx.navigation:navigation-fragment:$gradle.ext.navigationVersion"
implementation "androidx.navigation:navigation-ui:$gradle.ext.navigationVersion"
implementation "androidx.lifecycle:lifecycle-common:$androidxLifecycleVersion"
implementation "androidx.lifecycle:lifecycle-runtime:$androidxLifecycleVersion"
implementation "androidx.lifecycle:lifecycle-viewmodel:$androidxLifecycleVersion"
Expand Down
13 changes: 8 additions & 5 deletions settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
pluginManagement {
gradle.ext.kotlinVersion = '1.8.21'
gradle.ext.agpVersion = '7.2.1'
gradle.ext.googleServicesVersion = '4.3.15'
gradle.ext.navigationVersion = '2.5.3'
gradle.ext.sentryVersion = '3.5.0'
gradle.ext.daggerVersion = "2.46.1"
gradle.ext.detektVersion = '1.21.0'
gradle.ext.navComponentVersion = '2.4.2'
gradle.ext.violationCommentsVersion = '1.67'

plugins {
id "org.jetbrains.kotlin.android" version gradle.ext.kotlinVersion
Expand All @@ -14,11 +17,11 @@ pluginManagement {
id "org.jetbrains.kotlin.plugin.allopen" version gradle.ext.kotlinVersion
id "com.android.application" version gradle.ext.agpVersion
id "com.android.library" version gradle.ext.agpVersion
id 'com.google.gms.google-services' version '4.3.15'
id "io.sentry.android.gradle" version "3.5.0"
id 'com.google.gms.google-services' version gradle.ext.googleServicesVersion
id "androidx.navigation.safeargs.kotlin" version gradle.ext.navigationVersion
id "io.sentry.android.gradle" version gradle.ext.sentryVersion
id "io.gitlab.arturbosch.detekt" version gradle.ext.detektVersion
id "se.bjurr.violations.violation-comments-to-github-gradle-plugin" version "1.67"
id "androidx.navigation.safeargs.kotlin" version gradle.ext.navComponentVersion
id "se.bjurr.violations.violation-comments-to-github-gradle-plugin" version gradle.ext.violationCommentsVersion
}
repositories {
maven {
Expand Down