-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Dependency Updates] Update navigationVersion to 2.5.3
#18554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Notes: https://developer.android.com/jetpack/androidx/releases/ navigation#version_242_3
3 tasks
Contributor
|
Found 1 violations: The PR caused the following dependency changes: +--- project :libs:image-editor
-| +--- androidx.navigation:navigation-fragment:2.4.2
-| | +--- androidx.fragment:fragment-ktx:1.4.1 -> 1.5.7 (*)
-| | +--- androidx.navigation:navigation-runtime:2.4.2
-| | | +--- androidx.navigation:navigation-common:2.4.2
-| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-| | | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.6.1 (*)
-| | | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.6.1 (*)
-| | | | +--- androidx.savedstate:savedstate:1.0.0 -> 1.2.1 (*)
-| | | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.6.1 (*)
-| | | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.21 (*)
-| | | | +--- androidx.core:core-ktx:1.1.0 -> 1.10.0 (*)
-| | | | \--- androidx.collection:collection-ktx:1.1.0 (*)
-| | | +--- androidx.activity:activity-ktx:1.2.3 -> 1.7.1 (*)
-| | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.6.1 (*)
-| | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.6.1 (*)
-| | | +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
-| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.21 (*)
-| | +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.21 (*)
+| +--- androidx.navigation:navigation-fragment:2.5.3
+| | +--- androidx.fragment:fragment-ktx:1.5.4 -> 1.5.7 (*)
+| | +--- androidx.navigation:navigation-runtime:2.5.3
+| | | +--- androidx.activity:activity-ktx:1.5.1 -> 1.7.1 (*)
+| | | +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
+| | | +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
+| | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1 -> 2.6.1 (*)
+| | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1 -> 2.6.1 (*)
+| | | +--- androidx.navigation:navigation-common:2.5.3
+| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+| | | | +--- androidx.collection:collection-ktx:1.1.0 (*)
+| | | | +--- androidx.core:core-ktx:1.1.0 -> 1.10.0 (*)
+| | | | +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1 -> 2.6.1 (*)
+| | | | +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1 -> 2.6.1 (*)
+| | | | +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.6.1 (*)
+| | | | +--- androidx.savedstate:savedstate-ktx:1.2.0 -> 1.2.1 (*)
+| | | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.21 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.21 (*)
+| | +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.21 (*)
-| \--- androidx.navigation:navigation-ui:2.4.2
-| +--- androidx.navigation:navigation-runtime:2.4.2 (*)
-| +--- androidx.customview:customview:1.1.0 (*)
-| +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
-| +--- com.google.android.material:material:1.4.0-beta01 -> 1.9.0 (*)
-| +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
-| \--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
+| \--- androidx.navigation:navigation-ui:2.5.3
+| +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
+| +--- androidx.customview:customview:1.1.0 (*)
+| +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
+| +--- androidx.navigation:navigation-runtime:2.5.3 (*)
+| +--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
+| \--- com.google.android.material:material:1.4.0-beta01 -> 1.9.0 (*)
\--- com.automattic:about:1.1.0
\--- androidx.navigation:navigation-compose:2.4.0-beta02
\--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02
- +--- androidx.navigation:navigation-runtime:2.4.0-beta02 -> 2.4.2 (*)
+ +--- androidx.navigation:navigation-runtime:2.4.0-beta02 -> 2.5.3 (*)
\--- androidx.navigation:navigation-common-ktx:2.4.0-beta02
- \--- androidx.navigation:navigation-common:2.4.0-beta02 -> 2.4.2 (*)
+ \--- androidx.navigation:navigation-common:2.4.0-beta02 -> 2.5.3 (*)
Please review and act accordingly
|
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18554-cfe9456 | |
| Commit | cfe9456 | |
| Direct Download | wordpress-prototype-build-pr18554-cfe9456.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18554-cfe9456 | |
| Commit | cfe9456 | |
| Direct Download | jetpack-prototype-build-pr18554-cfe9456.apk |
ovitrif
approved these changes
Jun 12, 2023
Contributor
ovitrif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and the Image editing still works as described 🎉
Contributor
Author
|
This is awesome, thank you so much for reviewing, testing and merging this @ovitrif , you rock! 🙇 ❤️ 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Parent #17935
This PR updates
navigationVersionto 2.5.3.PS: @ovitrif I added you as the main reviewer, randomly so, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.
Build Refactor List:
Plugin Dependency Refactor List:
To test:
Image Editing Flow [libs:image-editor]
ℹ️ This test applies to both, the
WordPressandJetpackapps.blogpost.imageblock.imageblock.media optionsof this image (top right) and then clickedit.Edit Imagescreen is shown and functioning as expected.donemenu option (top right).Regression Notes
Potential unintended areas of impact
Image Editingscreen, which is closely related toandroidx.navigation.What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: