Skip to content

Conversation

@ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented May 30, 2023

Parent #17935

This PR updates navigationVersion to 2.5.3.


PS: @ovitrif I added you as the main reviewer, randomly so, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.


Build Refactor List:

  1. Rename nav component to navigation version
  2. Move navigation below the agp version and plugin ids

Plugin Dependency Refactor List:

  1. Extract google services plugin related version
  2. Extract sentry plugin related version
  3. Extract violation comments plugin related version

To test:

  1. See the dependency tree diff result and verify correctness.
  2. Thoroughly smoke test any navigation related functionality both, the WordPress and Jetpack apps, and see if everything is working as expected.
  3. In addition to the above smoke test, you can expand the below and follow the inner and more explicitly test steps within:
Image Editing Flow [libs:image-editor]

ℹ️ This test applies to both, the WordPress and Jetpack apps.

  • Add a new blog post.
  • Add a new image block.
  • Choose an image and wait for it to be uploaded within the image block.
  • Click on the media options of this image (top right) and then click edit.
  • Verify that the Edit Image screen is shown and functioning as expected.
  • Crop the image and click the done menu option (top right).
  • Make sure the image is updated accordingly.

Regression Notes

  1. Potential unintended areas of impact

    • Potential breakage or misbehaviour on any or all navigation related functionality, especially the Image Editing screen, which is closely related to androidx.navigation.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To test section above.
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@ParaskP7 ParaskP7 added this to the Future milestone May 30, 2023
@ParaskP7 ParaskP7 requested review from a team and ovitrif May 30, 2023 17:15
@ParaskP7 ParaskP7 self-assigned this May 30, 2023
@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:image-editor
-|    +--- androidx.navigation:navigation-fragment:2.4.2
-|    |    +--- androidx.fragment:fragment-ktx:1.4.1 -> 1.5.7 (*)
-|    |    +--- androidx.navigation:navigation-runtime:2.4.2
-|    |    |    +--- androidx.navigation:navigation-common:2.4.2
-|    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.6.1 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.6.1 (*)
-|    |    |    |    +--- androidx.savedstate:savedstate:1.0.0 -> 1.2.1 (*)
-|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.6.1 (*)
-|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.21 (*)
-|    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.10.0 (*)
-|    |    |    |    \--- androidx.collection:collection-ktx:1.1.0 (*)
-|    |    |    +--- androidx.activity:activity-ktx:1.2.3 -> 1.7.1 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.3.1 -> 2.6.1 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.3.1 -> 2.6.1 (*)
-|    |    |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.21 (*)
-|    |    +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.0 -> 1.8.21 (*)
+|    +--- androidx.navigation:navigation-fragment:2.5.3
+|    |    +--- androidx.fragment:fragment-ktx:1.5.4 -> 1.5.7 (*)
+|    |    +--- androidx.navigation:navigation-runtime:2.5.3
+|    |    |    +--- androidx.activity:activity-ktx:1.5.1 -> 1.7.1 (*)
+|    |    |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
+|    |    |    +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1 -> 2.6.1 (*)
+|    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1 -> 2.6.1 (*)
+|    |    |    +--- androidx.navigation:navigation-common:2.5.3
+|    |    |    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+|    |    |    |    +--- androidx.collection:collection-ktx:1.1.0 (*)
+|    |    |    |    +--- androidx.core:core-ktx:1.1.0 -> 1.10.0 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-runtime-ktx:2.5.1 -> 2.6.1 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.1 -> 2.6.1 (*)
+|    |    |    |    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.5.1 -> 2.6.1 (*)
+|    |    |    |    +--- androidx.savedstate:savedstate-ktx:1.2.0 -> 1.2.1 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.21 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.21 (*)
+|    |    +--- androidx.slidingpanelayout:slidingpanelayout:1.2.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.21 -> 1.8.21 (*)
-|    \--- androidx.navigation:navigation-ui:2.4.2
-|         +--- androidx.navigation:navigation-runtime:2.4.2 (*)
-|         +--- androidx.customview:customview:1.1.0 (*)
-|         +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
-|         +--- com.google.android.material:material:1.4.0-beta01 -> 1.9.0 (*)
-|         +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
-|         \--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
+|    \--- androidx.navigation:navigation-ui:2.5.3
+|         +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.0 (*)
+|         +--- androidx.customview:customview:1.1.0 (*)
+|         +--- androidx.drawerlayout:drawerlayout:1.1.1 (*)
+|         +--- androidx.navigation:navigation-runtime:2.5.3 (*)
+|         +--- androidx.transition:transition:1.3.0 -> 1.4.1 (*)
+|         \--- com.google.android.material:material:1.4.0-beta01 -> 1.9.0 (*)
 \--- com.automattic:about:1.1.0
      \--- androidx.navigation:navigation-compose:2.4.0-beta02
           \--- androidx.navigation:navigation-runtime-ktx:2.4.0-beta02
-               +--- androidx.navigation:navigation-runtime:2.4.0-beta02 -> 2.4.2 (*)
+               +--- androidx.navigation:navigation-runtime:2.4.0-beta02 -> 2.5.3 (*)
                \--- androidx.navigation:navigation-common-ktx:2.4.0-beta02
-                    \--- androidx.navigation:navigation-common:2.4.0-beta02 -> 2.4.2 (*)
+                    \--- androidx.navigation:navigation-common:2.4.0-beta02 -> 2.5.3 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18554-cfe9456
Commitcfe9456
Direct Downloadwordpress-prototype-build-pr18554-cfe9456.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18554-cfe9456
Commitcfe9456
Direct Downloadjetpack-prototype-build-pr18554-cfe9456.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the Image editing still works as described 🎉

@ovitrif ovitrif merged commit 491f4fc into trunk Jun 12, 2023
@ovitrif ovitrif deleted the deps/update-navigation-to-2.5.3 branch June 12, 2023 10:28
@ParaskP7
Copy link
Contributor Author

This is awesome, thank you so much for reviewing, testing and merging this @ovitrif , you rock! 🙇 ❤️ 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants