-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Dependency Updates] Update firebaseBomVersion to 32.1.0
#18552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v22-0-0 ------------------------------------------------------------------------ FYI: - Removed dependency on the deprecated Firebase Instance ID SDK. - Changed to open an 'Activity' directly when a notification is tapped instead of passing it through 'FirebaseMessagingService'. This change is to comply with Android 12 notification trampoline restrictions. - Internal changes to support dynamic feature modules.
It is generally recommended that transitively used dependencies should be declared directly. ------------------------------------------------------------------------ FYI: In this specific case and as per the Firebase 'Messaging' version '22.0.0' release notes, there exist a caution that this is a breaking change for apps that use FCM and the deprecated Firebase Instance ID API to manage registration tokens. First and foremost, it is strongly recommended to migrate to FCM's token APIs. But, if that is not possible, then, adding a direct dependency on the 'firebase-iid' library is the recommended way going forward, which is exactly what this commit is about. For more info see: https://firebase.google.com/support/release-notes/ android#messaging_v22-0-0
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-0-0 ------------------------------------------------------------------------ FYI: Added methods for determining and controlling whether Google Play services is set as the app’s notification delegate. By default, FCM will now set Google Play services as the app’s notification delegate so that it is allowed to display notifications for the app. This could be used in the future to show an app’s notifications without needing to start the app, which may improve message reliability and timeliness.
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-0-1 ------------------------------------------------------------------------ FYI: On Android 7.0 and earlier, the SDK now logs that a notification was opened after onActivityCreated to avoid a race condition when unparceling the extras Bundle. PS: Note the fact that this update is actually failing to build on 2 files found with path 'META-INF/DEPENDENCIES' from inputs (due to the 'httpcomponents' transitive dependency). Updating to '23.0.2' fixes this build failure.
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-0-2 ------------------------------------------------------------------------ FYI: Fixed an issue where the messaging component in the Firebase Android BoM leaked the 'httpcomponents' transitive dependencies.
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-0-3 ------------------------------------------------------------------------ FYI: Changed to catch 'RuntimeException' when getting the 'Bundle' from an 'Activity Intent' while checking for notification analytics data.
Release Notes: N/A
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-0-5 ------------------------------------------------------------------------ FYI: Upgraded logging priority for message delivery events to avoid dropped logs.
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-0-6 ------------------------------------------------------------------------ FYI: Added the 'POST_NOTIFICATIONS' permission to enable posting notifications when targeting SDK level 33.
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-0-7 ------------------------------------------------------------------------ FYI: Message broadcasts now finish immediately after binding to the service. This change should reduce the chance of ANRs.
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-0-8
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-1-0 ------------------------------------------------------------------------ FYI: - Updated to accommodate the release of the updated Cloud Messaging Kotlin extensions library. - Firebase now supports Kotlin coroutines.
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-1-1 ------------------------------------------------------------------------ FYI: Fixed deadlock when handling simultaneous messages.
Release Notes: https://firebase.google.com/support/release-notes/ android#messaging_v23-1-2 ------------------------------------------------------------------------ FYI: Fixed a breakage related to Jetpack core library related to an upstream update.
Release Notes: https://firebase.google.com/support/release-notes/ android#bom_v32-1-0 BOM Mapping: https://firebase.google.com/support/release-notes/ android#compare-bom-versions ------------------------------------------------------------------------ Firebase - Deprecated - com.google.firebase:firebase-iid -> N/A Firebase - Main - com.google.firebase:firebase-messaging -> 23.1.2 ------------------------------------------------------------------------ You will notice that the deprecated 'firebase-iid' dependency doesn't have a BOM mapping. As such this dependency will continue using an explicit versions (aka '21.1.0'). For more info see: - Firebase BOM doesnt' include com.google.firebase:firebase-iid #1077 firebase/firebase-android-sdk#1077 - [🐛][ 🔥] Cannot build in Android Studio after upgrading firebase/app past 9.0.0 #4847 invertase/react-native-firebase#4847 #issuecomment-1027904521
5 tasks
Contributor
|
Found 1 violations: The PR caused the following dependency changes:++--- com.google.android.gms:play-services-code-scanner:16.0.0-beta3
+| +--- com.google.android.datatransport:transport-api:2.2.1 -> 3.0.0
+| | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+| +--- com.google.android.datatransport:transport-backend-cct:2.3.3 -> 3.1.8
+| | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+| | +--- com.google.android.datatransport:transport-api:3.0.0 (*)
+| | +--- com.google.android.datatransport:transport-runtime:3.1.8
+| | | +--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+| | | +--- com.google.android.datatransport:transport-api:3.0.0 (*)
+| | | +--- com.google.firebase:firebase-encoders:17.0.0
+| | | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+| | | +--- com.google.firebase:firebase-encoders-proto:16.0.0
+| | | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+| | | | \--- com.google.firebase:firebase-encoders:17.0.0 (*)
+| | | \--- javax.inject:javax.inject:1
+| | +--- com.google.firebase:firebase-encoders:17.0.0 (*)
+| | \--- com.google.firebase:firebase-encoders-json:18.0.0
+| | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+| | \--- com.google.firebase:firebase-encoders:17.0.0 (*)
+| +--- com.google.android.datatransport:transport-runtime:2.2.6 -> 3.1.8 (*)
+| +--- com.google.firebase:firebase-components:16.1.0 -> 17.1.0
+| | +--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
+| | +--- com.google.errorprone:error_prone_annotations:2.9.0 -> 2.15.0
+| | \--- com.google.firebase:firebase-annotations:16.2.0
+| | \--- javax.inject:javax.inject:1
+| +--- com.google.firebase:firebase-encoders:16.1.0 -> 17.0.0 (*)
+| +--- com.google.firebase:firebase-encoders-json:17.1.0 -> 18.0.0 (*)
+| \--- com.google.mlkit:barcode-scanning-common:17.0.0
+| \--- com.google.mlkit:vision-common:17.0.0
+| +--- com.google.android.datatransport:transport-api:2.2.1 -> 3.0.0 (*)
+| +--- com.google.android.datatransport:transport-backend-cct:2.3.3 -> 3.1.8 (*)
+| +--- com.google.android.datatransport:transport-runtime:2.2.6 -> 3.1.8 (*)
+| +--- com.google.firebase:firebase-components:16.1.0 -> 17.1.0 (*)
+| +--- com.google.firebase:firebase-encoders:16.1.0 -> 17.0.0 (*)
+| +--- com.google.firebase:firebase-encoders-json:17.1.0 -> 18.0.0 (*)
+| \--- com.google.mlkit:common:18.0.0 -> 18.5.0
+| +--- com.google.android.datatransport:transport-api:2.2.1 -> 3.0.0 (*)
+| +--- com.google.android.datatransport:transport-backend-cct:2.3.3 -> 3.1.8 (*)
+| +--- com.google.android.datatransport:transport-runtime:2.2.6 -> 3.1.8 (*)
+| +--- com.google.firebase:firebase-components:16.1.0 -> 17.1.0 (*)
+| +--- com.google.firebase:firebase-encoders:16.1.0 -> 17.0.0 (*)
+| \--- com.google.firebase:firebase-encoders-json:17.1.0 -> 18.0.0 (*)
++--- com.google.firebase:firebase-bom:32.1.0
+| +--- com.google.firebase:firebase-messaging:23.1.2 (c)
+| +--- com.google.firebase:firebase-encoders:17.0.0 (c)
+| +--- com.google.firebase:firebase-common:20.3.2 (c)
+| \--- com.google.firebase:firebase-installations:17.1.3 (c)
++--- com.google.firebase:firebase-messaging -> 23.1.2
+| +--- com.google.firebase:firebase-common:20.3.1 -> 20.3.2
+| | +--- com.google.firebase:firebase-annotations:16.2.0 (*)
+| | +--- com.google.firebase:firebase-components:17.1.0 (*)
+| | +--- androidx.concurrent:concurrent-futures:1.1.0 (*)
+| | +--- com.google.android.gms:play-services-basement:18.1.0 (*)
+| | \--- com.google.android.gms:play-services-tasks:18.0.2 (*)
+| +--- com.google.firebase:firebase-components:17.1.0 (*)
+| +--- com.google.firebase:firebase-installations-interop:17.1.0
+| | +--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+| | \--- com.google.firebase:firebase-annotations:16.1.0 -> 16.2.0 (*)
+| +--- com.google.firebase:firebase-datatransport:18.1.7
+| | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+| | +--- com.google.android.datatransport:transport-api:3.0.0 (*)
+| | +--- com.google.android.datatransport:transport-backend-cct:3.1.8 (*)
+| | +--- com.google.android.datatransport:transport-runtime:3.1.8 (*)
+| | +--- com.google.firebase:firebase-common:20.2.0 -> 20.3.2 (*)
+| | \--- com.google.firebase:firebase-components:17.0.1 -> 17.1.0 (*)
+| +--- com.google.android.datatransport:transport-api:3.0.0 (*)
+| +--- com.google.android.datatransport:transport-runtime:3.1.8 (*)
+| +--- com.google.android.datatransport:transport-backend-cct:3.1.8 (*)
+| +--- com.google.firebase:firebase-encoders:17.0.0 (*)
+| +--- com.google.firebase:firebase-encoders-json:18.0.0 (*)
+| +--- com.google.firebase:firebase-encoders-proto:16.0.0 (*)
+| +--- com.google.firebase:firebase-installations:17.1.3
+| | +--- com.google.firebase:firebase-common:20.3.1 -> 20.3.2 (*)
+| | +--- com.google.firebase:firebase-installations-interop:17.1.0 (*)
+| | +--- com.google.firebase:firebase-components:17.1.0 (*)
+| | +--- com.google.firebase:firebase-annotations:16.2.0 (*)
+| | \--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+| +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+| +--- com.google.android.gms:play-services-tasks:18.0.1 -> 18.0.2 (*)
+| +--- com.google.android.gms:play-services-basement:18.1.0 (*)
+| +--- com.google.android.gms:play-services-base:18.0.1 -> 18.1.0 (*)
+| +--- com.google.android.gms:play-services-stats:17.0.2
+| | +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
+| | \--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+| +--- com.google.firebase:firebase-measurement-connector:19.0.0
+| | +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
+| | \--- com.google.firebase:firebase-annotations:16.0.0 -> 16.2.0 (*)
+| +--- com.google.firebase:firebase-iid-interop:17.1.0
+| | +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
+| | \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
+| +--- com.google.android.gms:play-services-cloud-messaging:17.0.1
+| | +--- com.google.android.gms:play-services-basement:18.0.0 -> 18.1.0 (*)
+| | \--- com.google.android.gms:play-services-tasks:18.0.0 -> 18.0.2 (*)
+| \--- com.google.errorprone:error_prone_annotations:2.9.0 -> 2.15.0
+\--- com.google.firebase:firebase-iid:21.1.0
+ +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
+ +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
+ +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
+ +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
+ +--- com.google.android.gms:play-services-cloud-messaging:16.0.0 -> 17.0.1 (*)
+ +--- com.google.android.gms:play-services-stats:17.0.0 -> 17.0.2 (*)
+ +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
+ +--- com.google.firebase:firebase-common:19.5.0 -> 20.3.2 (*)
+ +--- com.google.firebase:firebase-components:16.1.0 -> 17.1.0 (*)
+ +--- com.google.firebase:firebase-iid-interop:17.1.0 (*)
+ +--- com.google.firebase:firebase-installations:16.3.5 -> 17.1.3 (*)
+ \--- com.google.firebase:firebase-installations-interop:16.0.1 -> 17.1.0 (*)
-+--- com.google.firebase:firebase-messaging:21.1.0
-| +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
-| +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
-| +--- com.google.android.datatransport:transport-api:2.2.0 -> 2.2.1
-| | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-| +--- com.google.android.datatransport:transport-backend-cct:2.3.3
-| | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-| | +--- com.google.android.datatransport:transport-api:2.2.1 (*)
-| | +--- com.google.android.datatransport:transport-runtime:2.2.5 -> 2.2.6
-| | | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-| | | +--- com.google.android.datatransport:transport-api:2.2.1 (*)
-| | | \--- javax.inject:javax.inject:1
-| | +--- com.google.firebase:firebase-encoders:16.1.0
-| | | \--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-| | \--- com.google.firebase:firebase-encoders-json:17.1.0
-| | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-| | \--- com.google.firebase:firebase-encoders:16.1.0 (*)
-| +--- com.google.android.datatransport:transport-runtime:2.2.0 -> 2.2.6 (*)
-| +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
-| +--- com.google.android.gms:play-services-cloud-messaging:16.0.0
-| | +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
-| | \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
-| +--- com.google.android.gms:play-services-stats:17.0.0
-| | +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
-| | \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
-| +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
-| +--- com.google.firebase:firebase-common:19.5.0
-| | +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
-| | +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
-| | \--- com.google.firebase:firebase-components:16.1.0
-| | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-| | \--- com.google.firebase:firebase-annotations:16.0.0
-| +--- com.google.firebase:firebase-components:16.1.0 (*)
-| +--- com.google.firebase:firebase-datatransport:17.0.10
-| | +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-| | +--- com.google.android.datatransport:transport-api:2.2.1 (*)
-| | +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
-| | +--- com.google.android.datatransport:transport-runtime:2.2.5 -> 2.2.6 (*)
-| | +--- com.google.firebase:firebase-common:19.5.0 (*)
-| | \--- com.google.firebase:firebase-components:16.1.0 (*)
-| +--- com.google.firebase:firebase-encoders:16.1.0 (*)
-| +--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
-| +--- com.google.firebase:firebase-iid:21.1.0
-| | +--- androidx.collection:collection:1.0.0 -> 1.2.0 (*)
-| | +--- androidx.core:core:1.0.0 -> 1.10.0 (*)
-| | +--- androidx.legacy:legacy-support-core-utils:1.0.0 (*)
-| | +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
-| | +--- com.google.android.gms:play-services-cloud-messaging:16.0.0 (*)
-| | +--- com.google.android.gms:play-services-stats:17.0.0 (*)
-| | +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
-| | +--- com.google.firebase:firebase-common:19.5.0 (*)
-| | +--- com.google.firebase:firebase-components:16.1.0 (*)
-| | +--- com.google.firebase:firebase-iid-interop:17.1.0
-| | | +--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
-| | | \--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
-| | +--- com.google.firebase:firebase-installations:16.3.5
-| | | +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
-| | | +--- com.google.firebase:firebase-common:19.5.0 (*)
-| | | +--- com.google.firebase:firebase-components:16.1.0 (*)
-| | | \--- com.google.firebase:firebase-installations-interop:16.0.1
-| | | +--- com.google.android.gms:play-services-tasks:17.0.0 -> 18.0.2 (*)
-| | | \--- com.google.firebase:firebase-annotations:16.0.0
-| | \--- com.google.firebase:firebase-installations-interop:16.0.1 (*)
-| +--- com.google.firebase:firebase-iid-interop:17.1.0 (*)
-| +--- com.google.firebase:firebase-installations:16.3.5 (*)
-| +--- com.google.firebase:firebase-installations-interop:16.0.1 (*)
-| \--- com.google.firebase:firebase-measurement-connector:18.0.0
-| \--- com.google.android.gms:play-services-basement:17.0.0 -> 18.1.0 (*)
-\--- com.google.android.gms:play-services-code-scanner:16.0.0-beta3
- +--- com.google.android.datatransport:transport-api:2.2.1 (*)
- +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
- +--- com.google.android.datatransport:transport-runtime:2.2.6 (*)
- +--- com.google.firebase:firebase-components:16.1.0 (*)
- +--- com.google.firebase:firebase-encoders:16.1.0 (*)
- +--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
- \--- com.google.mlkit:barcode-scanning-common:17.0.0
- \--- com.google.mlkit:vision-common:17.0.0
- +--- com.google.android.datatransport:transport-api:2.2.1 (*)
- +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
- +--- com.google.android.datatransport:transport-runtime:2.2.6 (*)
- +--- com.google.firebase:firebase-components:16.1.0 (*)
- +--- com.google.firebase:firebase-encoders:16.1.0 (*)
- +--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
- \--- com.google.mlkit:common:18.0.0 -> 18.5.0
- +--- com.google.android.datatransport:transport-api:2.2.1 (*)
- +--- com.google.android.datatransport:transport-backend-cct:2.3.3 (*)
- +--- com.google.android.datatransport:transport-runtime:2.2.6 (*)
- +--- com.google.firebase:firebase-components:16.1.0 (*)
- +--- com.google.firebase:firebase-encoders:16.1.0 (*)
- \--- com.google.firebase:firebase-encoders-json:17.1.0 (*)
Please review and act accordingly
|
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18552-5aadaf4 | |
| Commit | 5aadaf4 | |
| Direct Download | wordpress-prototype-build-pr18552-5aadaf4.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18552-5aadaf4 | |
| Commit | 5aadaf4 | |
| Direct Download | jetpack-prototype-build-pr18552-5aadaf4.apk |
ravishanker
approved these changes
May 30, 2023
Contributor
ravishanker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for taking care of this 🚀
Contributor
Author
|
Awesome, thank you for reviewing, testing and merging this @ravishanker , you rock! 🙇 ❤️ 🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Parent #17567
This PR migrates to BOM and uses the
firebaseBomVersionupdate as of 32.1.0. To be more specific, this PR actually updatesfirebaseMessagingVersionto 23.1.2.Also, as part of this update the below transitive dependencies were added:
WordPressmodule (5c1eeba):com.google.firebase:firebase-iid(DEPRECATED)PS: @ravishanker I added you as the main reviewer, randomly so, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.
To test:
Push Notification on Post Being Published [GCMMessageService.java]
ℹ️ This test applies to both, the
WordPressandJetpackapps.blogpost.FYI: You could also use this Push Notifications Debug Console tool to verify that push notifications work as expected.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: