-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint Warnings - Resolve MissingFirebaseInstanceTokenRefresh
#18185
Labels
Milestone
Comments
Generated by 🚫 dangerJS |
3 similar comments
Generated by 🚫 dangerJS |
Generated by 🚫 dangerJS |
Generated by 🚫 dangerJS |
ParaskP7
changed the title
Lint Warnings - Resolve MissingFirebaseInstanceTokenRefresh
Lint Warnings - Resolve Mar 28, 2023
MissingFirebaseInstanceTokenRefresh
15 tasks
ParaskP7
added a commit
that referenced
this issue
Mar 28, 2023
This Lint warning is within lint config and removed from the Lint's baseline in order to make it app, product flavor and build type agnostic as it was otherwise polluting the baseline with 6 duplicate warnings, per app (WordPress and Jetpack), per product flavor (Jalapeno, Wasabi and Vanilla) and build type (Debug and Release). Related: Lint Warnings - Resolve 'MissingFirebaseInstanceTokenRefresh' - #18185
ParaskP7
added a commit
that referenced
this issue
Mar 28, 2023
This Lint warning is moved within lint config and removed from Lint's baseline in order to make it app, product flavor and build type agnostic as it was otherwise polluting the baseline with 6 duplicate warnings, per app (WordPress and Jetpack), per product flavor (Jalapeno, Wasabi and Vanilla) and build type (Debug and Release). Related: Lint Warnings - Resolve 'MissingFirebaseInstanceTokenRefresh' - #18185
7 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of the #18161 task, this
MissingFirebaseInstanceTokenRefresh
got suppressed and moved within the lint.xml file (instead of it being within the baseline.xml file and multiplied).This was done because in order to make this warning
app
,product flavor
andbuild type
agnostic as it was otherwise polluting the baseline with 6+ duplicate warnings, per app (WordPress
andJetpack
), per product flavor (Jalapeno
,Wasabi
andVanilla
) and build type (Debug
andRelease
).However, this warning should be fixed instead and that's what this issue is about, to try and resolve these warnings instead of suppressing it (expand to see details).
Issue Details
Message:
Apps that use Firebase Cloud Messaging should implement 'onNewToken()' in order to observe token changes"
The text was updated successfully, but these errors were encountered: