Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Warnings - Resolve MissingFirebaseInstanceTokenRefresh #18185

Open
Tracked by #18142
ParaskP7 opened this issue Mar 28, 2023 · 4 comments
Open
Tracked by #18142

Lint Warnings - Resolve MissingFirebaseInstanceTokenRefresh #18185

ParaskP7 opened this issue Mar 28, 2023 · 4 comments

Comments

@ParaskP7
Copy link
Contributor

ParaskP7 commented Mar 28, 2023

As part of the #18161 task, this MissingFirebaseInstanceTokenRefresh got suppressed and moved within the lint.xml file (instead of it being within the baseline.xml file and multiplied).

This was done because in order to make this warning app, product flavor and build type agnostic as it was otherwise polluting the baseline with 6+ duplicate warnings, per app (WordPress and Jetpack), per product flavor (Jalapeno, Wasabi and Vanilla) and build type (Debug and Release).

However, this warning should be fixed instead and that's what this issue is about, to try and resolve these warnings instead of suppressing it (expand to see details).

Issue Details
    <issue
        id="MissingFirebaseInstanceTokenRefresh"
        message="Apps that use Firebase Cloud Messaging should implement `onNewToken()` in order to observe token changes"
        errorLine1="abstract class Hilt_GCMMessageService extends FirebaseMessagingService implements GeneratedComponentManagerHolder {"
        errorLine2="               ~~~~~~~~~~~~~~~~~~~~~~">
        <location
            file="build/generated/source/kapt/**/org/wordpress/android/push/Hilt_GCMMessageService.java"
            line="16"
            column="16"/>
    </issue>

Message: Apps that use Firebase Cloud Messaging should implement 'onNewToken()' in order to observe token changes"

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

3 similar comments
@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@ParaskP7 ParaskP7 changed the title Lint Warnings - Resolve MissingFirebaseInstanceTokenRefresh Lint Warnings - Resolve MissingFirebaseInstanceTokenRefresh Mar 28, 2023
ParaskP7 added a commit that referenced this issue Mar 28, 2023
This Lint warning is within lint config and removed from the Lint's
baseline in order to make it app, product flavor and build type agnostic
as it was otherwise polluting the baseline with 6 duplicate warnings,
per app (WordPress and Jetpack), per product flavor (Jalapeno, Wasabi
and Vanilla) and build type (Debug and Release).

Related: Lint Warnings - Resolve 'MissingFirebaseInstanceTokenRefresh'
- #18185
ParaskP7 added a commit that referenced this issue Mar 28, 2023
This Lint warning is moved within lint config and removed from Lint's
baseline in order to make it app, product flavor and build type agnostic
as it was otherwise polluting the baseline with 6 duplicate warnings,
per app (WordPress and Jetpack), per product flavor (Jalapeno, Wasabi
and Vanilla) and build type (Debug and Release).

Related: Lint Warnings - Resolve 'MissingFirebaseInstanceTokenRefresh'
- #18185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant