Fix inconsistent background color of domain list in dark theme on landscape #18320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18269
This PR provides a very simple approach to fix the issue, basically adapting the existing implementation to use the proper Compose theme wrapper utility that we already had in the code.
To Test
Prerequisite
◐ Toggle the
SiteCreationDomainPurchasingFeatureConfig
flagMe
→App Settings
→Debug settings
Features in development
sectionRESTART THE APP
button● Treatment Variation
Verify the background color of domain list in site creation matches the screen bg in dark theme on landscape
Preview
Regression Notes
Potential unintended areas of impact
N/a
What I did to test those areas of impact (or what existing automated tests I relied on)
N/a
What automated tests I added (or what prevented me from doing so)
N/a
PR submission checklist:
RELEASE-NOTES.txt
if necessary.UI Changes testing checklist: