Skip to content

Commit

Permalink
Merge pull request #18320 from wordpress-mobile/try/18269-quick-fix
Browse files Browse the repository at this point in the history
Fix inconsistent background color of domain list in dark theme on landscape
  • Loading branch information
mkevins authored Apr 26, 2023
2 parents 993cc6b + 5cb463b commit 5c1a695
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import org.wordpress.android.R
import org.wordpress.android.databinding.SiteCreationDomainsItemBinding
import org.wordpress.android.databinding.SiteCreationDomainsItemV2Binding
import org.wordpress.android.databinding.SiteCreationSuggestionsErrorItemBinding
import org.wordpress.android.ui.compose.theme.AppTheme
import org.wordpress.android.ui.compose.theme.AppThemeWithoutBackground
import org.wordpress.android.ui.sitecreation.domains.SiteCreationDomainsViewModel.ListItemUiState.New
import org.wordpress.android.ui.sitecreation.domains.SiteCreationDomainsViewModel.ListItemUiState.Old
import org.wordpress.android.ui.sitecreation.domains.SiteCreationDomainsViewModel.ListItemUiState.Old.DomainUiState.AvailableDomain
Expand Down Expand Up @@ -72,7 +72,7 @@ sealed class SiteCreationDomainViewHolder<T : ViewBinding>(protected val binding

fun onBind(uiState: New.DomainUiState) = with(binding) {
composeView.setContent {
AppTheme {
AppThemeWithoutBackground {
DomainItem(uiState)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import org.wordpress.android.R.string
import org.wordpress.android.ui.compose.components.SolidCircle
import org.wordpress.android.ui.compose.theme.AppTheme
import org.wordpress.android.ui.compose.theme.AppThemeWithoutBackground
import org.wordpress.android.ui.compose.unit.Margin
import org.wordpress.android.ui.compose.utils.asString
import org.wordpress.android.ui.sitecreation.domains.SiteCreationDomainsViewModel.ListItemUiState.New.DomainUiState
Expand Down Expand Up @@ -186,7 +186,7 @@ private fun DomainItemPreview() {
onClick = {}
)
}
AppTheme {
AppThemeWithoutBackground {
Column {
uiStates.forEach { DomainItem(it) }
}
Expand Down

0 comments on commit 5c1a695

Please sign in to comment.