-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix/16689 notifications not dismissing when logged out #16694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/16689 notifications not dismissing when logged out #16694
Conversation
…t-dismissing-when-logged-out
|
Hi, I resolved that issue : #16694 |
AjeshRPai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carl-duncan Thanks for working on this. The fix looks good. I have tested as per the instructions. I have left a suggestion, Please let me know if you need any additional info.
WordPress/src/main/java/org/wordpress/android/util/NotificationsUtilsWrapper.kt
Outdated
Show resolved
Hide resolved
Generated by 🚫 dangerJS |
|
Hello @AjeshRPai , I resolved the suggested change. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
@carl-duncan Thanks for making the suggested change. I have triggered the CI. Once that is completed successfully I will merge the PR. 👍🏼 🙌🏼 |
|
You can test the changes on this Pull Request by downloading the APKs: |
|
Good news @carl-duncan: your fix has made its way to the version |
Fixes #16689
Notifications are now deleted when a user logs out
To test:
Login to the app
Create Post/Reply to a comment(finish any tasks which creates a notification)
Dont dismiss the notification
Logout from the app
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
3. What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.