Skip to content

Conversation

@carl-duncan
Copy link
Contributor

@carl-duncan carl-duncan commented Jun 2, 2022

Fixes #16689
Notifications are now deleted when a user logs out

To test:

Login to the app
Create Post/Reply to a comment(finish any tasks which creates a notification)
Dont dismiss the notification
Logout from the app

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

N/A
3. What automated tests I added (or what prevented me from doing so)

N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@carl-duncan
Copy link
Contributor Author

Hi, I resolved that issue : #16694

Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carl-duncan Thanks for working on this. The fix looks good. I have tested as per the instructions. I have left a suggestion, Please let me know if you need any additional info.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@carl-duncan
Copy link
Contributor Author

Hello @AjeshRPai , I resolved the suggested change.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 13, 2022

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@AjeshRPai
Copy link
Contributor

@carl-duncan Thanks for making the suggested change. I have triggered the CI. Once that is completed successfully I will merge the PR. 👍🏼 🙌🏼

@AjeshRPai AjeshRPai self-requested a review June 13, 2022 07:58
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APKs:

@AjeshRPai AjeshRPai merged commit 47798e8 into wordpress-mobile:trunk Jun 13, 2022
@AliSoftware
Copy link
Contributor

Good news @carl-duncan: your fix has made its way to the version 20.1 that we started to progressively roll out to end users this morning 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notifications doesnt dismiss after logging out from the App

3 participants