Skip to content

Commit 47798e8

Browse files
authored
Merge pull request #16694 from carl-duncan/fix/16689-notifications-not-dismissing-when-logged-out
Fix/16689 notifications not dismissing when logged out
2 parents 8a601be + 24f984d commit 47798e8

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

WordPress/src/main/java/org/wordpress/android/ui/main/MeFragment.kt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ import org.wordpress.android.ui.accounts.HelpActivity.Origin.ME_SCREEN_HELP
4848
import org.wordpress.android.ui.main.MeViewModel.RecommendAppUiState
4949
import org.wordpress.android.ui.main.WPMainActivity.OnScrollToTopListener
5050
import org.wordpress.android.ui.main.utils.MeGravatarLoader
51+
import org.wordpress.android.ui.notifications.utils.NotificationsUtils
5152
import org.wordpress.android.ui.photopicker.MediaPickerConstants
5253
import org.wordpress.android.ui.photopicker.MediaPickerLauncher
5354
import org.wordpress.android.ui.photopicker.PhotoPickerActivity.PhotoPickerMediaSource
@@ -393,7 +394,10 @@ class MeFragment : Fragment(R.layout.me_fragment), OnScrollToTopListener {
393394
.setMessage(message)
394395
.setPositiveButton(
395396
R.string.signout
396-
) { _, _ -> signOutWordPressCom() }
397+
) { _, _ ->
398+
clearNotifications()
399+
signOutWordPressCom()
400+
}
397401
.setNegativeButton(R.string.cancel, null)
398402
.setCancelable(true)
399403
.create().show()
@@ -403,6 +407,10 @@ class MeFragment : Fragment(R.layout.me_fragment), OnScrollToTopListener {
403407
viewModel.signOutWordPress(requireActivity().application as WordPress)
404408
}
405409

410+
private fun clearNotifications() {
411+
NotificationsUtils.cancelAllNotifications(requireActivity())
412+
}
413+
406414
private fun showDisconnectDialog() {
407415
disconnectProgressDialog = ProgressDialog.show(
408416
requireContext(),

WordPress/src/main/java/org/wordpress/android/ui/notifications/utils/NotificationsUtils.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ static FormattableContent mapJsonToFormattableContent(FormattableContentMapper m
172172
return mapper.mapToFormattableContent(blockObject.toString());
173173
}
174174

175+
public static void cancelAllNotifications(Context context) {
176+
NotificationManagerCompat.from(context).cancelAll();
177+
}
178+
175179
static SpannableStringBuilder getSpannableContentForRanges(
176180
FormattableContentMapper formattableContentMapper,
177181
JSONObject blockObject, TextView textView,

0 commit comments

Comments
 (0)