-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment - Gutenberg Android X migration #10020
Conversation
…t needed for RN60 add packingOptions as we can't build without it
Generated by 🚫 dangerJS |
Point to the latest gutenberg mobile ref
Rollback aztecVersion to 1.3.27 Remove packagingOptions from build.gradle
…x_build Gutenberg/Android X: Apply Java 1.8 compileOptions even when building from binaries
Tested this PR and LGTM! I was able to build both from local src, and remote artifacts. Let me know @marecar3 if other tests are needed, I just see we're using RN 0.6.0-RC1, but i guess it's safe to use it for the moment, otherwise we can't move forward our prjs. |
Thanks @daniloercoli ! |
I was also able to build both from local src, and remote artifacts. |
With v0.60 being a RC still, let's just test it out even more, ideally on the iOS side too, and look out for points of interest from the changelog that we might need to test. It feels like the 0.60 release is not far although it will probably miss our code-freeze Monday so, yeah, let's test it out and we will probably merge before the 0.60 gets promoted to full release. |
…ch when user query is cleared
…tions-on-clear Issue/10087 domain suggestions on clear
Will retarget this PR to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested after latest changes on the Analytics side for the unsupported blocks list and works as expected.
Just noticed on a clean installation of the app - building the app with GB-src-code-mode set to OFF - WPAndroid hash c63e1e7, gutenberg-mobile hash 4107bf6e - that it doesn't show the Video block. |
Indeed, as @marecar3 has found out, we disabled the block in the v1.8 editor release so it stayed disabled in here too because we've updated from develop. Decided to just revert the release-notes.txt changes in this PR and enable the block in the v1.9 release PRs. |
Updates the Gutenberg mobile ref to point to the latest work, including the effort to migrate to AndroidX.
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1112
To test:
Update release notes:
RELEASE-NOTES.txt
.