0.60.x Discussion

[grabbou]

0.60.0-rc.0 is most likely going to be released tomorrow. The branch is already cut. We are working on the changelog.

Stay tuned.

[radeno]

@grabbou I think better timing for cut first RC should be next week. Easter holidays are behind door and many developers will not work. Even first RC-0 will be as fresh as possible next week.

[rhdeck]

Was the delay monday decided? Or is the drop happening today (Friday)? Looking to test the hot new autolinking.

[turnrye]

@rhdeck yes, we're delaying the publish til Monday. We'll have a WIP changelog today, though it'll still need a lot of refinement.

[grabbou]

Yes. The release is ready to go and tests are passing. I wanted to wait for the changelog because the amount of changes is quite big and we want to wrap it up on the CLI side too.

[Vyazovoy]

Any chances it will be published this week?

[piashcse]

is there any possibility to release 0.60-rc.0 by next week?

[grabbou]

Yes, the plan is to release it this week, ideally before Wednesday. We are still waiting for one CLI issue to be fixed, others have been already resolved.

…

On Fri, 26 Apr 2019 at 03:53, Mehedi Hassan Piash ***@***.***> wrote: is there any possibility to release 0.60-rc0 by next week? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AASZZRT66RHVFOAAU2XPDE3PSJOBFANCNFSM4HGX2LDA> .

[grabbou]

0.60 is currently blocked due to CocoaPods integration. We have recently migrated default template to CocoaPods but want to avoid users running pod install after react-native init.

Our work can be tracked here: facebook/react-native#24638, tho we are hitting blocker after blocker.

Heading off to holidays, will be back on Monday and that's most likely when I resume my work on the CLI where additional support has to be added.

[jeveloper]

Hope you have a great holiday man , good for you @grabbou

[Salakar]

Any chance we could cherry pick these two small commits:

• facebook/react-native@bdb1d43
• facebook/react-native@88dbb45

[mikehardy]

@Salakar - I don't think 0.60 is cut yet, so that comment might best be on 0.59.x for cherry pick?

[sunnylqm]

@mikehardy Already cut and was planned to publish last week https://github.com/facebook/react-native/commits/0.60-stable

[grabbou]

Yes. I can include them too once we are done with the CocoaPods issue.

Update: Unfortunately, the approach in facebook/react-native#24638 ended up being a dead end. We will be running pod install on the client side (meaning you need to have CocoaPods pre-installed).

We are going to implement this ticket react-native-community/cli#368 and we will ship 0.60 as soon as it's resolved.

Unfortunately, given the amount of things to coordinate for 0.60, I can't give you any promises. I will try to do my best to ship it as soon as possible tho.

[jsamr]

Please cherry-pick facebook/react-native@c5c79e5 which prevent a memory leak on iOS!

EDIT Apparently, there is a header issue after having been merged. It's being fixed

[jsamr]

And it would be marvelous if we had font family support in Android, which has just been merged into master facebook/react-native@fd6386a. This PR makes Android xml font declarations operable within the React Native framework.

Basically, it means that you can have mixed nested font styles for custom fonts (fontFamily, fontStyle and fontWeight) without the need to use postscript font name such as OpenSans-Bold). An example is provided in the commit if you want to know how to achieve that.

[danilobuerger]

Is 0.60 going to be recut? If not, please cherry pick

• [Android] [Fixed] - LayoutAnimations cause invalid view operations facebook/react-native@20b4879
  and its dependent commits.

(This was already requested for 0.59.5, but couldn't be cherry picked because of a dependent commit)

This fixes quite a few crashes when using LayoutAnimations, so its definitely worth picking in my opinion.

[radeno]

I agree with @danilobuerger about recutting new RC0. 22 days from first recut is long time. Many fine bugfixes and some new improvements are very promising to have in first release candidate. But i don't know how much time it takes and how much new problems and issues will appear after merging commits.

[jinshin1013]

Can we also cherry pick this if it's not too late?:

• [iOS] Fixes tintColor not changing on Gif image on iOS facebook/react-native@75380aa

[grabbou]

We will look into re-cutting 0.60 before making the first release. Depending on the tests and stability, we may or may not do it.

I will update you in this issue. Meanwhile, please wait a bit with suggesting cherry-picks until you give the first release a go.

[rhdeck]

Is there a new timeframe? We're four weeks past "most likely going to be released tomorrow." We all know things take time, but would help my dev efforts to have a rough undertstanding of when this would be pre-release, but on npm.

[kelset]

Ok quick update: I've managed to cherry pick

• facebook/react-native@2dd7dd8
• facebook/react-native@6c0eccd

and

• facebook/react-native@261197d (which should bring back the full autolink feature for iOS - and now both platforms should then "use it")

The other two commits:

• facebook/react-native@6001acb

• facebook/react-native@d9a8ac5

were already in the branch.

Which leads me two a good news and a bad news:

• my test with these cherry-picks went ✅
• the issue with the scheduler version is not actually fixed, and we are talking with the FB engineers to come up with a solution. But it's likely that it will need to use a yarn resolution in the package.json.

I will not release the RC2 until I know what we will do about the scheduler thing, I'll update here asap.

[kelset]

Hey everyone! Thanks to the help of @rickhanlonii we found a solution for the scheduler for RC2, and now RC2 is out 🚀

This will likely be the last RC before 0.60.0, unless something huge bubbles up. So please, test it and let us know if you have any regressions 🤗

(as always, please open an issue in the main repo & just post here a link so that we can keep track of the conversation more easily!)

---

EDIT: nope just got some news on a feature that we want to add to 0.60, we'll do another RC next week just to be safe 😇

[mikehardy]

@kelset thanks for the patience on the regression @robertying found (and fixed) 💪 when this PR lands it fixes things facebook/react-native#25363

[kelset]

Hey everyone, it seems that that extra feature will not land in the end.

But since we have a few Android commits that needs to be cherry picked:

• facebook/react-native@3915c0f
• bump fresco to 2.0.0, supports AndroidX facebook/react-native#25358
• facebook/react-native@58beaf0

I'll probably still do a RC3 first this week.

---

EDIT: it seems that there is an issue with pods facebook/react-native#25349 so I'll wait to get more feedback on that before doing the RC

[doublex]

Could you apply facebook/react-native@690e85d in 0.60?

[kelset]

Hey everyone - quick update. By end of this week I'm expecting a couple of PRs to land that we want to cherry pick:

• a bump to the CLI to rc3
• an update for the JSC which should solve most of the issues related to Android 64b builds

And there is a small chance that we'll have a fix for the use_frameworks! pod config.
We'll do a RC3 when those two commits land, and likely 0.60.0 will be the release after.

[kelset]

Hey everyone 👋

I just finished cherry picking + testing the commits above, plus the ones described (bump to CLI RC & JSC for Android) - it should be rolling out any minute now.

For the iOS use_framework! issue there is a PR in the work but it will likely not be ready in time when we want to release 0.60.0.

In the meantime, please test RC3 and report if you are seeing any massive issues via opening an issue in the main repo & posting the link here!

[brunolemos]

ItemSeparatorComponent fix to cherry pick: facebook/react-native@1e42809

[thymikee]

Include react-native.config.js in publish list: facebook/react-native@44c05da

[RoJoHub]

Could you apply facebook/react-native@fb550e9

[auchaphon]

Include facebook/react-native@76c50c1 Please

[kelset]

👋 everyone!

Thanks for the latest feedback, I just pushed the commit to trigger the release for 0.60.0 - let's close this and see you in the cherry pick request issue -> #130

[cbpanchal]

@grabbou Please check, react-native version 0.60.4 run android stuck and it takes too much time to compile. help me to short out this

Thanks