-
Notifications
You must be signed in to change notification settings - Fork 120
Showcase Wormholy 1.7.0 SwiftPM issue #15663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
mokagio
wants to merge
16
commits into
ainfra-216-migrate-woocommerce-ios-from-cocoapods-to-spm
from
mokagio/show-wormholy-issue
Closed
Showcase Wormholy 1.7.0 SwiftPM issue #15663
mokagio
wants to merge
16
commits into
ainfra-216-migrate-woocommerce-ios-from-cocoapods-to-spm
from
mokagio/show-wormholy-issue
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice this also remove the Woo App WatchOS target from CocoaPods.
Collaborator
Generated by 🚫 Danger |
6d2ba1b to
336878b
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see from CI or by attempting the package resolution locally, the current stable Wormholy version is not compatible with the latest Swift package manager:
This is consistent with what's reported in pmusolino/Wormholy#154, which is where I would start looking for a solution.
In the meantime, as discussed internally, ref p91TBi-diV-p2, we'll remove Wormholy just so we can close the CocoaPods migration project, see https://linear.app/a8c/issue/AINFRA-216