-
Notifications
You must be signed in to change notification settings - Fork 120
Migrate from CocoaPods to SwiftPM in Modules #15658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from CocoaPods to SwiftPM in Modules #15658
Conversation
Generated by 🚫 Danger |
703df05 to
0a09f7b
Compare
|
|
6d2ba1b to
336878b
Compare
| 269014D42BEA9335006056E0 /* UserAgent.swift in Sources */ = {isa = PBXBuildFile; fileRef = 45551F112523E7F1007EF104 /* UserAgent.swift */; }; | ||
| 26AE25F52C6C0A110032A600 /* Account.swift in Sources */ = {isa = PBXBuildFile; fileRef = B505F6CE20BEE38B00BB1B69 /* Account.swift */; }; | ||
| 26B15E442A269F79000C35E4 /* ip-location.json in Resources */ = {isa = PBXBuildFile; fileRef = 26B15E432A269F79000C35E4 /* ip-location.json */; }; | ||
| 26B542452BEAC6A6003A55B5 /* Pods_NetworkingWatchOS.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 6132DCC72AA9C070E2033628 /* Pods_NetworkingWatchOS.framework */; }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the framework projects no longer have pods target, therefore a lot of CocoaPods plumbing has been removed from their project files.
But keep in mind, the project files will soon disappear, too, with the move of the frameworks to packages.
| @@ -1,6 +1,15 @@ | |||
| { | |||
| "originHash" : "9ea1ab4271974e9606eddf01e2528d962e975d6abd3fb314fae28d3eeeb07fe9", | |||
| "originHash" : "30ecaceed4e1b487697506426e20d60843bbce1a647790dd9bc8b78d8b2edcf7", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I commented in #15654 that I'm surprised we still have the Package.resolved in the workspace when there are no longer package dependencies there, only the internal Modules package.
Xcode keeps generating this file, so there must be something still configured for it in there.
I'm delaying tackling this inconsistency till after having moved everything to SwiftPM. It should be simpler to diagnose then, with less moving parts in Xcode itself.
| import Combine | ||
| import Foundation | ||
| import Kingfisher | ||
| import UIKit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some import required tweaking after the move to SwiftPM. I haven't investigate, but my guess is that the packaging and linking is slightly different and therefore some headers that were implicitly part of the linkage no longer are. As you can see, the footprint is small.
67239b8 to
e6bd110
Compare
Notice this also remove the Woo App WatchOS target from CocoaPods.
e6bd110 to
487d618
Compare
41ac1c5 to
dcabc22
Compare
staskus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project continues to work as before 👍

Description
See https://linear.app/a8c/issue/AINFRA-216 and its sub-issues.
This PR uses the set up established by #15654 to move all pods to SwiftPM, except for:
Steps to reproduce && Testing information
See green CI and that the prototype build for a spin.
Screenshots
RELEASE-NOTES.txtif necessary.