Skip to content

Conversation

@wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Dec 1, 2025

See https://github.com/woocommerce/woocommerce-gateway-stripe/pull/4787/files#r2549080282

Changes proposed in this Pull Request:

In this PR, I am just deprecating all the occurrences of LPM_GATEWAY_CLASS so we can remove them in the next version, as requested by @daledupreez.

Testing instructions

Code review. These constants are not used anymore since we deprecated the legacy checkout.


  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Dec 1, 2025
@wjrosa wjrosa marked this pull request as ready for review December 1, 2025 15:10
@wjrosa wjrosa requested review from a team, Mayisha and malithsen and removed request for a team December 1, 2025 15:12
Copy link
Contributor

@malithsen malithsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Mayisha Mayisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@wjrosa wjrosa merged commit 2185525 into develop Dec 2, 2025
42 checks passed
@wjrosa wjrosa deleted the dev/deprecating-lpm-class-constants branch December 2, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants