[DO NOT MERGE] Removing legacy payment method classes #4787

wjrosa · 2025-11-12T19:12:45Z

Changes proposed in this Pull Request:

In this simple cleanup PR, I am removing all the legacy checkout payment method classes, as we are no longer using them.

Testing instructions

Code review. Check if the tests are still passing. Perform some basic smoke testing and confirm no regression was introduced.

Covered with tests (or have a good reason not to test in description ☝️)
Tested on mobile (or does not apply)

Changelog entry

This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Comment

Comment

Post merge

Added testing instructions to the Release Testing Instructions wiki page (or does not apply)
Added the needs docs label (or does not apply)
Included this PR in the Release Thread scope (or does not apply)

malithsen

Looks good. Are we planning to do a similar cleanup for the frontend code (to remove is_upe_enabled distinction) in a separate PR?

daledupreez

I have some initial comments from inspection, and I will move to test this later this morning. That said, it feels like it might be worth splitting this PR up a bit so we can tackle more specific and focused testing.

includes/admin/class-wc-rest-stripe-settings-controller.php

includes/admin/class-wc-stripe-admin-notices.php

includes/class-wc-stripe-helper.php

includes/class-wc-stripe.php

daledupreez · 2025-11-14T07:42:31Z

tests/phpunit/Admin/Migrations/WC_Stripe_Subscriptions_Repairer_Legacy_SEPA_Tokens_Test.php

 	 * @var string
 	 */
-	private $legacy_sepa_gateway_id = WC_Gateway_Stripe_Sepa::ID;
+	private $legacy_sepa_gateway_id = 'stripe_sepa';


Might it be worth using a new constant for this rather than having 'stripe_sepa' everywhere?

It also feels like it could be worth pushing just that change into a dedicated PR, as that would be easy to inspect and review, and we could get it shipped with minimal risk. That would also reduce the size of this PR by quite a few files.

includes/admin/class-wc-rest-stripe-settings-controller.php

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

wjrosa · 2025-11-14T11:33:23Z

Looks good. Are we planning to do a similar cleanup for the frontend code (to remove is_upe_enabled distinction) in a separate PR?

@malithsen yes. I have some other branches to push related to code cleaning up. I will open other PRs in the next couple of weeks

I have some initial comments from inspection, and I will move to test this later this morning. That said, it feels like it might be worth splitting this PR up a bit so we can tackle more specific and focused testing.

@daledupreez I tried to make this PR focused on just removing the payment method classes, to avoid it getting too big or risky. Which parts do you think would be better to move to another PR?

daledupreez · 2025-11-14T11:51:20Z

For splitting the PR, I was thinking it might make sense to change the references to WC_Gateway_Stripe_Sepa::ID (which occurs a few times) to 'stripe_sepa' (or another constant), as changing the string and what we reference can happen without removing the underlying class. It also touches quite a few files, but is pretty easy to validate from inspection alone, as this should be an implementation detail.

wjrosa · 2025-11-14T12:47:47Z

Oh right. I created the other PR here: #4802

daledupreez

While I would love to remove all of this code, I am really worried about unforeseen consequences of removing so much code without looking deeply into some of the nuances of what we're changing and/or removing.

daledupreez · 2025-11-21T09:08:58Z

includes/abstracts/abstract-wc-stripe-payment-gateway.php

 		}

 		// Bail if no Stripe payment method is enabled.
-		if ( 'no' === $this->enabled && empty( WC_Stripe_Helper::get_legacy_enabled_payment_methods() ) ) {


Question: should we be queuing these scripts for any pages when UPE is enabled?

includes/class-wc-stripe-helper.php

daledupreez · 2025-11-21T09:19:06Z

includes/class-wc-stripe-helper.php

-	 * @deprecated 9.6.0 The customization of individual payment methods is now deprecated.
+	 * @deprecated 10.2.0 This method will be removed in future versions.
 	 */
-	public static function get_legacy_individual_payment_method_settings() {


Nit: It feels like it would be worth splitting this out into a dedicated PR so we can correctly capture the removal in a changelog entry. I almost missed that these two functions had been removed.

daledupreez · 2025-11-21T09:20:59Z

includes/payment-methods/class-wc-gateway-stripe-alipay.php

- *
- * @since 4.0.0
- */
-class WC_Gateway_Stripe_Alipay extends WC_Stripe_Payment_Gateway {


These classes were not marked as deprecated. Just to be good citizens, I think we should deprecate them before removing them, as merchants may be referencing them in custom code.

Good point. New PR is here #4839

daledupreez · 2025-11-21T09:24:35Z

includes/payment-methods/class-wc-stripe-upe-payment-method-alipay.php


 	const STRIPE_ID = WC_Stripe_Payment_Methods::ALIPAY;

-	const LPM_GATEWAY_CLASS = WC_Gateway_Stripe_Alipay::class;


As with the class removals, I think we should deprecate these constants first, as they are public and could be in use.

Alright. New PR here #4838

daledupreez · 2025-11-21T09:26:52Z

includes/class-wc-stripe.php

 	protected function enable_upe( $settings ) {
 		$settings['upe_checkout_experience_accepted_payments'] = [];

-		$payment_gateways = WC_Stripe_Helper::get_legacy_payment_methods();


Can we safely remove this logic? What will happen to merchants upgrading from older versions where UPE was not enabled yet?

daledupreez · 2025-11-21T09:28:12Z

tests/phpunit/WC_Stripe_Helper_Test.php

 		];
 	}

-	public function test_turning_on_upe_enables_the_correct_upe_methods_based_on_which_legacy_payment_methods_were_enabled() {


Don't we still need the underlying logic for upgrades?

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

wjrosa added 2 commits October 26, 2025 12:37

Removing legacy payment method classes

18f5bd6

Merge branch 'develop' into dev/removing-legacy-payment-method-classes

953521e

wjrosa self-assigned this Nov 12, 2025

Changelog and readme entries

a9a385c

wjrosa changed the title ~~Dev/removing legacy payment method classes~~ Removing legacy payment method classes Nov 12, 2025

wjrosa marked this pull request as ready for review November 12, 2025 19:14

wjrosa added 3 commits November 12, 2025 16:22

Removing references to legacy methods

d29fe9f

Fix tests

ff70ab0

Removing implementation of unused methods

61382ac

wjrosa requested review from a team, daledupreez and malithsen and removed request for a team November 12, 2025 20:36

malithsen approved these changes Nov 13, 2025

View reviewed changes

daledupreez reviewed Nov 14, 2025

View reviewed changes

Merge branch 'develop' into dev/removing-legacy-payment-method-classes

d8d60b9

daledupreez reviewed Nov 14, 2025

View reviewed changes

includes/admin/class-wc-rest-stripe-settings-controller.php Outdated Show resolved Hide resolved

wjrosa and others added 10 commits November 14, 2025 08:22

Update includes/admin/class-wc-stripe-admin-notices.php

b1c4485

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

Update includes/class-wc-stripe-helper.php

5aeb669

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

Update includes/class-wc-stripe-helper.php

d1f0261

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

Update includes/class-wc-stripe-helper.php

4f5f93e

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

Update includes/class-wc-stripe-helper.php

c50b07a

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

Update includes/class-wc-stripe-helper.php

da98648

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

Update includes/class-wc-stripe-helper.php

8ad84cd

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

Merge branch 'develop' into dev/removing-legacy-payment-method-classes

f45297b

Update includes/class-wc-stripe-helper.php

953f466

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

Update includes/admin/class-wc-rest-stripe-settings-controller.php

c8715f2

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

wjrosa mentioned this pull request Nov 14, 2025

Replacing the SEPA legacy constant identifier #4802

Merged

6 tasks

wjrosa and others added 3 commits November 19, 2025 15:51

Merge branch 'develop' into dev/removing-legacy-payment-method-classes

299ff49

Merge branch 'develop' into dev/removing-legacy-payment-method-classes

c3fa27b

Merge branch 'develop' into dev/removing-legacy-payment-method-classes

5ed4bd0

wjrosa requested a review from daledupreez November 28, 2025 12:33

daledupreez reviewed Nov 28, 2025

View reviewed changes

wjrosa and others added 2 commits December 1, 2025 11:51

Merge branch 'develop' into dev/removing-legacy-payment-method-classes

5ce85ab

Update includes/class-wc-stripe-helper.php

a9d22d1

Co-authored-by: daledupreez <dale.du.preez@automattic.com>

wjrosa mentioned this pull request Dec 1, 2025

Deprecating all the legacy checkout payment method classes #4839

Merged

6 tasks

wjrosa added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Dec 1, 2025

wjrosa changed the title ~~Removing legacy payment method classes~~ [DO NOT MERGE] Removing legacy payment method classes Dec 1, 2025

Merge branch 'develop' into dev/removing-legacy-payment-method-classes

93d94ce


		const STRIPE_ID = WC_Stripe_Payment_Methods::ALIPAY;

		const LPM_GATEWAY_CLASS = WC_Gateway_Stripe_Alipay::class;

[DO NOT MERGE] Removing legacy payment method classes #4787

Are you sure you want to change the base?

[DO NOT MERGE] Removing legacy payment method classes #4787

Uh oh!

Conversation

wjrosa commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this Pull Request:

Testing instructions

Changelog entry

Comment

Uh oh!

malithsen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daledupreez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wjrosa commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daledupreez commented Nov 14, 2025

Uh oh!

wjrosa commented Nov 14, 2025

Uh oh!

daledupreez left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wjrosa commented Nov 12, 2025 •

edited

Loading

malithsen left a comment •

edited

Loading

wjrosa commented Nov 14, 2025 •

edited

Loading