Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency Cache] Enable Dependency Cache on CI [with GRADLE_RO_DEP_CACHE] #13122

Draft
wants to merge 18 commits into
base: trunk
Choose a base branch
from

Conversation

ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Dec 12, 2024

Related: #13170

Description

This is a test only PR that attempts to test the existing dependency cache mechanism, one that does dependent on the read-only cache (GRADLE_RO_DEP_CACHE), but per project.

Testing information

N/A

Tip

To verify that GRADLE_RO_DEP_CACHE is enabled make sure you do see this Shared read-only dependency cache is an incubating feature. log when Gradle launches for a CI build (example).

The tests that have been performed

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@ParaskP7 ParaskP7 added category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. Core status: do not merge Dependent on another PR, ready for review but not ready for merge. labels Dec 12, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 12, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitff41696
Direct Downloadwoocommerce-prototype-build-pr13122-ff41696.apk

@ParaskP7 ParaskP7 force-pushed the ci/enable-dependency-cache-on-ci branch 7 times, most recently from 5036933 to 91c8676 Compare December 13, 2024 13:12
@ParaskP7 ParaskP7 changed the title [Dependency Cache] Enable Dependency Cache on CI [Dependency Cache] Enable Dependency Cache on CI [Test Only] Dec 16, 2024
@ParaskP7 ParaskP7 force-pushed the ci/enable-dependency-cache-on-ci branch from 891e39e to 640942f Compare December 16, 2024 14:11
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 16, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitff41696
Direct Downloadwoocommerce-wear-prototype-build-pr13122-ff41696.apk

@ParaskP7 ParaskP7 force-pushed the ci/enable-dependency-cache-on-ci branch 6 times, most recently from c428113 to d31164c Compare December 17, 2024 15:35
FYI: This job will be then used by 'buildkite-ci' and configured as a
'buildkite_pipeline_schedule' with a weekly frequency.
This change points to that remote branch and commit where the
'GRADLE_RO_DEP_CACHE' environment variable is indeed set, and thus is
indeed pointing to the directory containing the cache.
This change points to that remote branch and commit where the
'GRADLE_RO_DEP_CACHE' environment variable is not set, and thus not
pointing to the directory containing the cache.
This should be now done automatically and via this another
standard Buildkite environment variable being the prefix, the
'BUILDKITE_PIPELINE_SLUG' environment variable.

For more info see: https://github.com/Automattic/
a8c-ci-toolkit-buildkite-plugin/pull/134/commits/
4d3f80b9f113076c9a8698f08d137ed591426150
@ParaskP7 ParaskP7 force-pushed the ci/enable-dependency-cache-on-ci branch from eea5e8c to 93bfc61 Compare December 19, 2024 10:46
@ParaskP7 ParaskP7 changed the title [Dependency Cache] Enable Dependency Cache on CI [Test Only] [Dependency Cache] Enable Dependency Cache on CI [with GRADLE_RO_DEP_CACHE] Dec 19, 2024
@ParaskP7 ParaskP7 force-pushed the ci/enable-dependency-cache-on-ci branch from 4af8801 to e6f3975 Compare December 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. Core status: do not merge Dependent on another PR, ready for review but not ready for merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants