Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bulk Update Orders] Feature flag. #13113

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

hafizrahman
Copy link
Contributor

@hafizrahman hafizrahman commented Dec 12, 2024

Part of: #13122

Description

Quick PR just to add a feature flag for the project.

Steps to reproduce

Nothing, just ensure everything builds fine.

Testing information

n/a

The tests that have been performed

Just tested by building the app.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@hafizrahman hafizrahman marked this pull request as ready for review December 12, 2024 06:12
@hafizrahman hafizrahman added this to the 21.3 milestone Dec 12, 2024
@hafizrahman hafizrahman added the type: task An internally driven task. label Dec 12, 2024
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit219a64c
Direct Downloadwoocommerce-wear-prototype-build-pr13113-219a64c.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit219a64c
Direct Downloadwoocommerce-prototype-build-pr13113-219a64c.apk

@irfano irfano self-assigned this Dec 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.41%. Comparing base (c891053) to head (219a64c).
Report is 168 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #13113   +/-   ##
=========================================
  Coverage     40.41%   40.41%           
  Complexity     6194     6194           
=========================================
  Files          1294     1294           
  Lines         74479    74480    +1     
  Branches      10188    10188           
=========================================
+ Hits          30097    30099    +2     
+ Misses        41771    41770    -1     
  Partials       2611     2611           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@irfano irfano merged commit a58e05d into trunk Dec 12, 2024
17 checks passed
@irfano irfano deleted the task/13112-bulk-update-order-ff branch December 12, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants