Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Added bower.json. #843

Closed
wants to merge 3 commits into from
Closed

Added bower.json. #843

wants to merge 3 commits into from

Conversation

codekipple
Copy link

Would you guys consider supporting bower?

I was trying to install FlexSlider via bower but was unable to set it to a particular version.

@soullivaneuh
Copy link

+1, and use tag version without "version/" prefix to avoid bower issue...

@kraftner
Copy link

+1, would be really awesome!

@blackjid
Copy link

👍

@siamkreative
Copy link

Please we need this!

@adis-me
Copy link

adis-me commented Apr 26, 2014

+1

1 similar comment
@marlenesco
Copy link

+1

@alangvara
Copy link

Would be great!

@danielgillespie
Copy link

+1

@mattyza mattyza mentioned this pull request Jun 4, 2014
@mattyza
Copy link
Member

mattyza commented Jun 4, 2014

@codekipple Is there any way to direct bower to a specific tagged release of a project? FlexSlider releases are all tagged, with the master branch serving as the development branch.

If we can direct bower to a specific tag, that would be great and we can merge this in. :)

@mattyza mattyza added this to the 2.3.0 milestone Jun 4, 2014
@codekipple
Copy link
Author

@mattyza Yep bower works by detecting tags. The tags do have to follow semvar. I'm not sure if your tags will currently work due to them having 'version/' in the tag name. I'll have to give it a try.

If they don't it would mean changing the way you name your tags in the future.

@mattyza
Copy link
Member

mattyza commented Jun 4, 2014

Right, that makes sense.

Please give it a test and let me know. :)

Matt Cohen
Chief Product Officer, WooThemes

http://woothemes.com/
http://matty.co.za/

On Wed, Jun 4, 2014 at 10:44 AM, codekipple notifications@github.com
wrote:

@mattyza https://github.com/mattyza Yep bower works by detecting tags.
The tags do have to follow semvar http://semver.org/. I'm not sure if
your tags will currently work due to them having 'version/' in the tag
name. I'll have to give it a try.

If they don't it would mean changing the way you name your tags in the
future.


Reply to this email directly or view it on GitHub
#843 (comment).

@loranger
Copy link

loranger commented Jun 4, 2014

@mattyza I cannot say better than @codekipple But you can take a look at the bower.json specifications. It seems bower does care about the semver format (for now) and get the tags chronologically, but you have to check beacause it looks kind of weird to me.

@sformisano
Copy link

+1 for all this guys, bower is really the de-facto standard for front-end dependency management so any serious library should support it these days!

@cheapsteak
Copy link

I've been trying to get flexslider to work with my Gulp setup which uses gulp-bower-files to concat the 3rd party plugins. Having trouble getting that to work without a bower.json :(

@samyerkes
Copy link

+1 definitely needed!

@g-roduit
Copy link

+1 here too!

@climboid
Copy link

Guys when is this going to be merged?? seems like a lot of people need it

@mattyza
Copy link
Member

mattyza commented Jul 16, 2014

@climboid Please read the conversation above. :)

@Sparticuz
Copy link

Here's what I had to do to get Bower working on a fork of this repo.

  1. I had to rename the tags. Bower doesn't like the version/ in front of the version number. (I guess you could probably just create the semver'ed tags instead of also deleting the old ones)
git tag 2.1 version/2.1
git tag 2.2 version/2.2
git tag 2.2.1 version/2.2.1
git tag 2.2.2 version/2.2.2
git tag -d version/2.1
git tag -d version/2.2
git tag -d version/2.2.1
git tag -d version/2.2.2
git push origin :refs/tags/version/2.1
git push origin :refs/tags/version/2.2
git push origin :refs/tags/version/2.2.1
git push origin :refs/tags/version/2.2.2
git push --tags
  1. Once the new tags were in place, add in the bower.json file. (The one in this pull request is not correct. The FlexSlider version is old and the jquery dep is wrong, should be 1.4.2, not 1.7)

That's it, then this repo will work correctly with bower.

@mattyza
Copy link
Member

mattyza commented Jul 17, 2014

Yeah, we won't be changing the tags, I reckon. :)

Is there any other benefit to changing the tag structure?

Matt Cohen
Chief Product Officer, WooThemes

http://woothemes.com/
http://matty.co.za/

On Wed, Jul 16, 2014 at 9:48 PM, Kyle McNally notifications@github.com
wrote:

Here's what I had to do to get Bower working on a fork of this repo.

  1. I had to rename the tags. Bower doesn't like the version/ in front of
    the version number. (I guess you could probably just create the semver'ed
    tags instead of also deleting the old ones)

git tag 2.1 version/2.1
git tag 2.2 version/2.2
git tag 2.2.1 version/2.2.1
git tag 2.2.2 version/2.2.2
git tag -d version/2.1
git tag -d version/2.2
git tag -d version/2.2.1
git tag -d version/2.2.2
git push origin :refs/tags/version/2.1
git push origin :refs/tags/version/2.2
git push origin :refs/tags/version/2.2.1
git push origin :refs/tags/version/2.2.2
git push --tags

  1. Once the new tags were in place, add in the bower.json file. (The one
    in this pull request is not correct. The FlexSlider version is old and the
    jquery dep is wrong, should be 1.4.2, not 1.7)

That's it, then this repo will work correctly with bower.


Reply to this email directly or view it on GitHub
#843 (comment).

@Sparticuz
Copy link

The benefit to changing the tag structure is with automatic updates, all a user would need to do to update to the latest FlexSlider would be

bower update

Currently, users can still manage FlexSlider using bower, it's just not automatic

bower install FlexSlider#version/2.2.2

Then when 2.3 comes out, the user will have to do an install using FlexSlider#version/2.3.

I did refork and just add the new tags (instead of also deleting them) and bower did work fine, detecting only the semversion'd tags. (Maybe you could add both tags in the future?)

@DonDi1989
Copy link

Can you also add "main" in .bower.json because we need that when we use "grunt-wiredep" ?

@climboid
Copy link

climboid commented Aug 5, 2014

If tags don't change we can't install automatically via bower and yeoman using grunt serve task. I really need the main in bower.json that @DonDi1989 . If there are no plans to update this please let us know and I'll create a separate bower package

@gephaest
Copy link

Please add bower support! It's standart in front-end.

@fritzblue
Copy link

+:100:

With all due respect, you guys are failing your user community something fierce w.r.t. this issue.

@jaylinski
Copy link

+1

@mpdude
Copy link

mpdude commented Feb 4, 2015

What about adding additional tags for current versions that are not prefixed with "version/"? Would that work for bower?

@jeffikus jeffikus modified the milestones: 2.4.0, 2.3.0 Feb 11, 2015
@doublemarked
Copy link

Would love to see this also. Currently bower will find and install the lib, but the lack of a bower.json is breaking other tools like wiredep.

@jeffikus jeffikus modified the milestones: 2.5.0, 2.4.0 Mar 9, 2015
@litchfield
Copy link

Come on guys, you can make thousands of people happy here with a single click of your mouse.

@adriantomic
Copy link

+1 for this. Wiredep won't work without a bower.json.

@Krigu
Copy link

Krigu commented Mar 19, 2015

+1. Would be really great!

@mpdude
Copy link

mpdude commented Mar 19, 2015

Only 964 more 👍 needed to get this merged. Spread the word!

@matgargano
Copy link

LETS DO THIS

@Bersam
Copy link

Bersam commented Mar 21, 2015

+1 for pull-request, but just as a workaround, you can override main property in your bower.json:
install FlexSlider like this:
bower install --save https://github.com/woothemes/FlexSlider.git
then override main property for wiredep like this:

...
"overrides": {
  "FlexSlider": {
    "main": [
      "jquery.flexslider.js",
      "flexslider.css"
    ]
  }
}
...

@jeffikus jeffikus self-assigned this Mar 24, 2015
@Kanti
Copy link

Kanti commented Mar 25, 2015

+1 👍

@DragosMocrii
Copy link

+1 Voted!

@DragosMocrii
Copy link

@Bersam

Can you please provide more detailed instructions how to make this work? I am new to bower and wiredep, so am unsure where to add the overrides parts exactly. Thanks!

@Bersam
Copy link

Bersam commented Apr 5, 2015

@DragosMocrii here's a sample of working bower.json with overrides for FlexSlider.
https://gist.github.com/Bersam/8f3747af74f3aab11926

@DragosMocrii
Copy link

@Bersam

Thank you!

@octavioamu
Copy link

I added this bower but would overwrite the bower.json. Just adding here because some examples are missing the dependencies.

{
  "name": "flexslider",
  "version": "1.3.15",
  "main": [
    "./jquery.flexslider-min.js",
    "./flexslider.css"
  ],
  "ignore": [],
  "dependencies": {
    "jquery": "~2"
  }
}

or my override:

...
"overrides": {
    "flexslider": {
      "main": [
        "./jquery.flexslider-min.js",
        "./flexslider.css"
      ],
      "ignore": [],
      "dependencies": {
        "jquery": "~2"
      }
    }
  },

...

@jeffikus jeffikus modified the milestones: 2.5.0, 2.6.0 May 22, 2015
@jeffikus
Copy link
Contributor

Hi guys, I've bumped this into the 2.6.0 release, you'll see it's focused on package managers in the release description I've planned! Thanks for your continued patience!

@jeffikus jeffikus closed this in 2dd420a May 27, 2015
jeffikus added a commit that referenced this pull request May 27, 2015
…npm. Watch for new 2.5.0 tag before using.
@soullivaneuh
Copy link

@jeffikus why adding all bower_components directory? This should be ignored.

@jeffikus jeffikus mentioned this pull request May 27, 2015
floq-design added a commit to floq-design/FlexSlider that referenced this pull request Aug 5, 2015
* commit '8ed61acca0a1c1f1242ebb0cdb8291be6d4a0d91':
  Closes woocommerce#843 - adds npm components and package json for registry with npm. Watch for new 2.5.0 tag before using.
  Closes woocommerce#843 - adds bower components and bower json for registry with bower. Watch for new 2.5.0 tag before using.
  Closes woocommerce#819 - Adds caption demo file
  Closes woocommerce#1321 - adds license file GPLv2 and later
  Merge changes between demo site on svn and git repo.
  Closes woocommerce#1143 - adds customDirectionNav param, fixes demo's and adds new demo for custom direction navigation controls. Updates changelog and readme.
  Updates changelog, readme, bumps support for jQuery 1.4.2 to 1.7+ Closes woocommerce#1312
  Closes woocommerce#1293 - CSS fix for pausePlay play icon.
  Working branch pushed to GitHub. Version updated.
  Fixes woocommerce#958. Declare onTouchStart, onTouchEnd, onTouchMove as function expressions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.