-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
+1, and use tag version without "version/" prefix to avoid bower issue... |
+1, would be really awesome! |
👍 |
Please we need this! |
+1 |
1 similar comment
+1 |
Would be great! |
+1 |
@codekipple Is there any way to direct bower to a specific tagged release of a project? FlexSlider releases are all tagged, with the master branch serving as the development branch. If we can direct bower to a specific tag, that would be great and we can merge this in. :) |
Right, that makes sense. Please give it a test and let me know. :) Matt Cohen http://woothemes.com/ On Wed, Jun 4, 2014 at 10:44 AM, codekipple notifications@github.com
|
@mattyza I cannot say better than @codekipple But you can take a look at the bower.json specifications. It seems bower does care about the semver format (for now) and get the tags chronologically, but you have to check beacause it looks kind of weird to me. |
+1 for all this guys, bower is really the de-facto standard for front-end dependency management so any serious library should support it these days! |
I've been trying to get flexslider to work with my Gulp setup which uses |
+1 definitely needed! |
+1 here too! |
Guys when is this going to be merged?? seems like a lot of people need it |
@climboid Please read the conversation above. :) |
Here's what I had to do to get Bower working on a fork of this repo.
That's it, then this repo will work correctly with bower. |
Yeah, we won't be changing the tags, I reckon. :) Is there any other benefit to changing the tag structure? Matt Cohen http://woothemes.com/ On Wed, Jul 16, 2014 at 9:48 PM, Kyle McNally notifications@github.com
|
The benefit to changing the tag structure is with automatic updates, all a user would need to do to update to the latest FlexSlider would be
Currently, users can still manage FlexSlider using bower, it's just not automatic
Then when 2.3 comes out, the user will have to do an install using FlexSlider#version/2.3. I did refork and just add the new tags (instead of also deleting them) and bower did work fine, detecting only the semversion'd tags. (Maybe you could add both tags in the future?) |
Can you also add "main" in .bower.json because we need that when we use "grunt-wiredep" ? |
If tags don't change we can't install automatically via bower and yeoman using grunt serve task. I really need the main in bower.json that @DonDi1989 . If there are no plans to update this please let us know and I'll create a separate bower package |
Please add bower support! It's standart in front-end. |
+:100: With all due respect, you guys are failing your user community something fierce w.r.t. this issue. |
+1 |
What about adding additional tags for current versions that are not prefixed with "version/"? Would that work for bower? |
Would love to see this also. Currently bower will find and install the lib, but the lack of a bower.json is breaking other tools like wiredep. |
Come on guys, you can make thousands of people happy here with a single click of your mouse. |
+1 for this. Wiredep won't work without a bower.json. |
+1. Would be really great! |
Only 964 more 👍 needed to get this merged. Spread the word! |
LETS DO THIS |
+1 for pull-request, but just as a workaround, you can override main property in your bower.json: ...
"overrides": {
"FlexSlider": {
"main": [
"jquery.flexslider.js",
"flexslider.css"
]
}
}
... |
+1 👍 |
+1 Voted! |
Can you please provide more detailed instructions how to make this work? I am new to bower and wiredep, so am unsure where to add the overrides parts exactly. Thanks! |
@DragosMocrii here's a sample of working bower.json with overrides for FlexSlider. |
Thank you! |
I added this bower but would overwrite the bower.json. Just adding here because some examples are missing the dependencies.
or my override:
|
Hi guys, I've bumped this into the 2.6.0 release, you'll see it's focused on package managers in the release description I've planned! Thanks for your continued patience! |
…npm. Watch for new 2.5.0 tag before using.
@jeffikus why adding all |
* commit '8ed61acca0a1c1f1242ebb0cdb8291be6d4a0d91': Closes woocommerce#843 - adds npm components and package json for registry with npm. Watch for new 2.5.0 tag before using. Closes woocommerce#843 - adds bower components and bower json for registry with bower. Watch for new 2.5.0 tag before using. Closes woocommerce#819 - Adds caption demo file Closes woocommerce#1321 - adds license file GPLv2 and later Merge changes between demo site on svn and git repo. Closes woocommerce#1143 - adds customDirectionNav param, fixes demo's and adds new demo for custom direction navigation controls. Updates changelog and readme. Updates changelog, readme, bumps support for jQuery 1.4.2 to 1.7+ Closes woocommerce#1312 Closes woocommerce#1293 - CSS fix for pausePlay play icon. Working branch pushed to GitHub. Version updated. Fixes woocommerce#958. Declare onTouchStart, onTouchEnd, onTouchMove as function expressions.
Would you guys consider supporting bower?
I was trying to install FlexSlider via bower but was unable to set it to a particular version.