This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
replaced jQuery 1.7 on() call with standard bind() #1312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on() is supported from jQuery 1.7 only (https://api.jquery.com/category/version/1.7/#post-461) and FlexSlider declares jQuery 1.3+ support.
|
Further reading as to why on() is better http://www.elijahmanor.com/differences-between-jquery-bind-vs-live-vs-delegate-vs-on/ |
floq-design
added a commit
to floq-design/FlexSlider
that referenced
this pull request
Aug 5, 2015
* commit '8ed61acca0a1c1f1242ebb0cdb8291be6d4a0d91': Closes woocommerce#843 - adds npm components and package json for registry with npm. Watch for new 2.5.0 tag before using. Closes woocommerce#843 - adds bower components and bower json for registry with bower. Watch for new 2.5.0 tag before using. Closes woocommerce#819 - Adds caption demo file Closes woocommerce#1321 - adds license file GPLv2 and later Merge changes between demo site on svn and git repo. Closes woocommerce#1143 - adds customDirectionNav param, fixes demo's and adds new demo for custom direction navigation controls. Updates changelog and readme. Updates changelog, readme, bumps support for jQuery 1.4.2 to 1.7+ Closes woocommerce#1312 Closes woocommerce#1293 - CSS fix for pausePlay play icon. Working branch pushed to GitHub. Version updated. Fixes woocommerce#958. Declare onTouchStart, onTouchEnd, onTouchMove as function expressions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on() is supported from jQuery 1.7 only and FlexSlider declares jQuery 1.3+ support. Fixing this by replacing on() call with standard bind() one - which is used all over the project anyway.