Build yara-x with increased memory, --target-dir for cargo-c, and optimizations #38392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imizations Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
octo-sts
bot
added
the
bincapz/pass
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
dannf
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some local Melange changes that made #38328 appear valid when in fact the build artifacts for
cargo-cwere still landing in/tmp.This PR specifies
--target-dirto redirectcargo-c's build artifacts to a non-/tmpdirectory to avoid running in to QEMU'snoexectmpfs.Once this was fixed, the
cargo-cinstall was OOM'ing with the default-m 4000000kconfiguration so I added a memory requirement of6Giwhich allowed the build to succeed. Finally, I addedopt-level=3to build theyara-x-capiwith all available optimizations.