Fix yara-x build in QEMU #38328
Merged
Fix yara-x build in QEMU #38328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
force-pushed
the
yara-x-qemu-friendly
branch
from
39a7da9 to
356be71
Compare
octo-sts
bot
added
the
bincapz/pass
developer-guy
approved these changes
Dec 25, 2024
egibs
added a commit
that referenced
this pull request
Dec 26, 2024
…imizations (#38392) I had some local Melange changes that made #38328 appear valid when in fact the build artifacts for `cargo-c` were still landing in `/tmp`. This PR specifies `--target-dir` to redirect `cargo-c`'s build artifacts to a non-`/tmp` directory to avoid running in to QEMU's `noexec` tmpfs. Once this was fixed, the `cargo-c` install was OOM'ing with the default `-m 4000000k` configuration so I added a memory requirement of `6Gi` which allowed the build to succeed. Finally, I added `opt-level=3` to build the `yara-x-capi` with all available optimizations. --------- Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that running
make package/yara-xwould fail when using the QEMU runner.This is due to
cargo install cargo-cleveraging/tmpwhich is mounted asnoexecin the QEMU runner:os/melange/init
Line 10 in 2825e0b
To comply with this restriction, this PR sets the installation root for
cargo-cto$HOME/.cargorather than/tmp.