Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby3.3-async/2.21.1 package update #38357

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 25, 2024

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 25, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 25, 2024

Gen AI suggestions to solve the build error:

Based on the provided build log and context, I'll analyze the error and provide a solution:

• Detected Error: There's no explicit error message shown in the log, but the build appears to be failing silently after dependency installation

• Error Category: Dependency

• Failure Point: After dependency installation, before the ruby/build step

• Root Cause Analysis: Looking at the package dependencies and the changelog showing worker pool changes, the package likely requires additional runtime dependencies that are missing, specifically io-event and timers gems which are core dependencies for the async worker pool functionality

• Suggested Fix:
Add these build-time dependencies to the environment section:

environment:
  contents:
    packages:
      - build-base
      - busybox
      - ca-certificates-bundle
      - git
      - ruby-${{vars.rubyMM}}
      - ruby-${{vars.rubyMM}}-dev
      - ruby${{vars.rubyMM}}-io-event
      - ruby${{vars.rubyMM}}-timers

• Explanation:

  • The async gem 2.21.1 update includes worker pool changes that require io-event and timers
  • These gems need to be available during build time, not just runtime
  • Adding them to the environment section ensures they're available during the build process

• Additional Notes:

  • The runtime dependencies section is correct
  • Consider adding explicit version constraints if needed
  • The test section should also include these dependencies for proper testing

• References:

Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
@developer-guy developer-guy self-assigned this Dec 25, 2024
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Dec 25, 2024
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@debasishbsws debasishbsws force-pushed the wolfictl-cf80c263-3a80-4a98-8bec-9715f451e109 branch from c1b6d7b to a0505e8 Compare December 26, 2024 07:42
@debasishbsws debasishbsws requested a review from a team December 26, 2024 07:47
@Dentrax Dentrax enabled auto-merge (squash) December 26, 2024 10:53
@Dentrax Dentrax merged commit b99a9b4 into main Dec 26, 2024
14 checks passed
@Dentrax Dentrax deleted the wolfictl-cf80c263-3a80-4a98-8bec-9715f451e109 branch December 26, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants