Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby3.2-async/2.21.1 package update #38187

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 21, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 21, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 21, 2024

Gen AI suggestions to solve the build error:

Based on the error output, I'll provide a structured analysis and solution:

• Detected Error:

patching file async.gemspec
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file async.gemspec.rej

• Error Category: Configuration/Patch

• Failure Point: The patch step failed when trying to apply "001-remove-signing-key.patch"

• Root Cause Analysis: The patch is failing to apply cleanly because the gemspec file structure has likely changed in version 2.21.1 compared to when the patch was created

• Suggested Fix:

  1. Update the patch file to match the new gemspec structure. Here's a likely corrected patch content:
--- a/async.gemspec
+++ b/async.gemspec
@@ -11,7 +11,6 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Samuel Williams"]
   spec.email         = ["samuel.williams@oriontransfer.co.nz"]
   
-  spec.cert_chain  = ['release.cert']
-  spec.signing_key = File.expand_path('~/.gem/release.pem')
-  
   spec.summary       = %q{A concurrency framework for Ruby.}
   spec.homepage      = "https://github.com/socketry/async"

• Explanation:

  • The patch is failing because line numbers or context in the gemspec file have changed
  • The updated patch removes the signing configuration while matching the current file structure
  • This is a common issue when package versions are updated and source files have been modified

• Additional Notes:

  • The patch failure is the only error in the build process
  • All other dependencies and build steps appear to be correct
  • The package update from the changelog doesn't indicate major structural changes
  • The failure is not related to the actual code changes in v2.21.1

• References:

To implement the fix:

  1. Update the "001-remove-signing-key.patch" file with the corrected patch content
  2. Commit the updated patch file
  3. Re-run the build

@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 25, 2024
@Dentrax Dentrax enabled auto-merge (squash) December 25, 2024 17:20
@Dentrax Dentrax self-assigned this Dec 25, 2024
ruby3.2-async.yaml Outdated Show resolved Hide resolved
@Dentrax
Copy link
Member

Dentrax commented Dec 26, 2024

Duplicate of #38357

@Dentrax Dentrax marked this as a duplicate of #38357 Dec 26, 2024
@Dentrax Dentrax closed this Dec 26, 2024
auto-merge was automatically disabled December 26, 2024 10:53

Pull request was closed

@debasishbsws
Copy link
Member

Not a duplicate the ruby version is different

@debasishbsws debasishbsws reopened this Dec 26, 2024
@Dentrax Dentrax enabled auto-merge (squash) December 26, 2024 14:27
wolfi-bot and others added 3 commits December 30, 2024 10:02
Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
Signed-off-by: Dentrax <furkan.turkal@chainguard.dev>
@mamccorm mamccorm force-pushed the wolfictl-c5f0e419-dc35-4fd3-b016-35716345c6ef branch from 704f074 to 12dc388 Compare December 30, 2024 10:02
@Dentrax Dentrax merged commit ee2b983 into main Dec 30, 2024
14 checks passed
@Dentrax Dentrax deleted the wolfictl-c5f0e419-dc35-4fd3-b016-35716345c6ef branch December 30, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants