Skip to content

Conversation

@dgarske
Copy link
Contributor

@dgarske dgarske commented Jun 23, 2025

Description

Fix for new api.c test test_wolfSSL_check_domain_basic added in PR #8863 that fails with --disable-sys-ca-certs.

Testing

./configure --disable-sys-ca-certs && make check

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Jun 23, 2025
@dgarske
Copy link
Contributor Author

dgarske commented Jun 24, 2025

Jenkins retest this please: "Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:"

@dgarske
Copy link
Contributor Author

dgarske commented Jun 24, 2025

Retest this please: "Found unhandled hudson.remoting.RequestAbortedException exception:" PRB-opensslextra.txt_20 and PRB-single-flag.txt_50

Copy link
Contributor

@bigbrett bigbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As @rlm2002 said, this test should have ran unconditionally, regardless of whether WOLFSSL_SYS_CA_CERTS is defined. We will fix in a subsequent PR

@dgarske dgarske removed their assignment Jun 24, 2025
@dgarske dgarske requested a review from douzzer June 24, 2025 20:28
@douzzer douzzer merged commit 6bfd263 into wolfSSL:master Jun 26, 2025
224 checks passed
@dgarske dgarske deleted the various_20250623 branch June 27, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants