-
Notifications
You must be signed in to change notification settings - Fork 921
Add api unit test for checking domain name #8863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5126478 to
7baaf19
Compare
use SNI example.com in client ssl
Contributor
Author
|
retest this please jenkins |
JacobBarthelmeh
approved these changes
Jun 11, 2025
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Jun 23, 2025
…olfSSL#8863 that fails with `--disable-sys-ca-certs`.
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Jun 23, 2025
…olfSSL#8863 that fails with `--disable-sys-ca-certs`.
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Jun 23, 2025
…olfSSL#8863 that fails with `--disable-sys-ca-certs`.
4 tasks
dgarske
reviewed
Jun 23, 2025
|
|
||
| #endif /* OPENSSL_EXTRA && HAVE_SSL_MEMIO_TESTS_DEPENDENCIES */ | ||
| #if defined(HAVE_SSL_MEMIO_TESTS_DEPENDENCIES) && \ | ||
| !defined(WOLFSSL_SYS_CA_CERTS) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just discovered this logic is wrong and put up a PR #8917
A simple ./configure --disable-sys-ca-certs && make was failing.
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Jun 24, 2025
…olfSSL#8863 that fails with `--disable-sys-ca-certs`.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a basic test for wolfSSL connection with matching and non matching domain names with
wolfSSL_check_domain_name().Will add additional configuration for Apple specific platform next.
Related to zd#19957 and PR#8833
Testing
Tested with
./configure --enable-alland running individual test.Checklist