Skip to content

Add missing return code handling for mldsa_vec_expand_mask. #11463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kareem-wolfssl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing return code handling for mldsa_vec_expand_mask. #11463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions wolfcrypt/src/wc_mldsa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9503,8 +9503,11 @@ static int mldsa_sign_with_seed_mu(wc_MlDsaKey* key,
byte* commit = sig;

/* Step 12: Compute vector y from private random seed and kappa. */
mldsa_vec_expand_mask(&key->shake, priv_rand_seed, kappa,
ret = mldsa_vec_expand_mask(&key->shake, priv_rand_seed, kappa,
params->gamma1_bits, y, params->l, key->heap);
if (ret != 0) {
break;
}
Comment on lines +9506 to +9510
#ifdef WOLFSSL_MLDSA_SIGN_CHECK_Y
valid = mldsa_vec_check_low(y, params->l,
((sword32)1 << params->gamma1_bits) - params->beta);
Expand Down Expand Up @@ -9802,8 +9805,11 @@ static int mldsa_sign_with_seed_mu(wc_MlDsaKey* key,

valid = 1;
/* Step 12: Compute vector y from private random seed and kappa. */
mldsa_vec_expand_mask(&key->shake, priv_rand_seed, kappa,
ret = mldsa_vec_expand_mask(&key->shake, priv_rand_seed, kappa,
params->gamma1_bits, y, params->l, key->heap);
if (ret != 0) {
break;
}
#ifdef WOLFSSL_MLDSA_SIGN_CHECK_Y
valid = mldsa_vec_check_low(y, params->l,
((sword32)1 << params->gamma1_bits) - params->beta);
Expand Down
Loading