Repository navigation
Add missing return code handling for mldsa_vec_expand_mask. - #11463
Open
kareem-wolfssl wants to merge 1 commit into
Open
kareem-wolfssl wants to merge 1 commit into
kareem-wolfssl wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The corrected error propagation lacks a regression test that verifies the exact failure is returned.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds error propagation for ML-DSA mask expansion during signing.
Changes:
- Checks
mldsa_vec_expand_mask()results. - Stops both signing paths immediately on failure.
File summaries
| File | Description |
|---|---|
wolfcrypt/src/wc_mldsa.c |
Handles mask-expansion errors in standard and small-memory signing paths. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+9506
to
+9510
| ret = mldsa_vec_expand_mask(&key->shake, priv_rand_seed, kappa, | ||
| params->gamma1_bits, y, params->l, key->heap); | ||
| if (ret != 0) { | ||
| break; | ||
| } |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11454
Testing
Built in tests
Checklist