Release 4.0.0 #82
Release 4.0.0 #82
Conversation
README.md
Outdated
|
|
||
| * Made the library a pure JavaScript library. | ||
| * Removed MediaWiki ResourceLoader module definitions. | ||
| * Raised DataValues JS library version requirement to 0.10.0. |
There was a problem hiding this comment.
Is it really necessary to drop the compatibility with DataValues JavaScript 0.9?
Also, I think we should use the exact name of the component: "DataValues JavaScript".
There was a problem hiding this comment.
It is necessary in my eyes, given dropping all php stuff and depending on the npm package (which only exists for 0.10).
Re names: well I can change it sure, but: the name you gave is neither name of the old packagist package nor the name of the npm package. So how it is the "exact name of the component"?
There was a problem hiding this comment.
It's "DataValues JavaScript", never "JS".
I think I understand why this isn't compatible with 0.9 any more. Thanks.
init.php
Outdated
| /** | ||
| * @deprecated since 3.0 | ||
| */ | ||
| define( 'WIKIBASE_DATAMODEL_JAVASCRIPT_VERSION', '4.0.0' ); |
There was a problem hiding this comment.
We usually mention the removal of constants in the release notes.
There was a problem hiding this comment.
hm, can say, although it says already there is only JS now there (thus no PHP constants).
There was a problem hiding this comment.
I manually rebased this after I merged #81 and GitHub run into a merge conflict that just disappeared locally. o_O? Feel free to merge this now if you are find with my additions.
Needed for https://phabricator.wikimedia.org/T177476. Blocking wmde/WikibaseSerializationJavaScript#47.
Note this contains commits from #81 which should be merged first. The only relevant commit here is dc44cff.