Skip to content

Prepare the library to be released as a npm package #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 9, 2017
Merged

Conversation

manicki
Copy link
Member

@manicki manicki commented Oct 5, 2017

@manicki manicki changed the title [DNM] Prepare the library to be released as a npm package Prepare the library to be released as a npm package Oct 6, 2017
@manicki manicki mentioned this pull request Oct 9, 2017
@@ -1,10 +1,31 @@
{
"name": "wikibase-data-model",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stick to tab-indention in all .json files. But this can be fixed later.

@@ -10,6 +10,9 @@ at the heart of the [Wikibase software](http://wikiba.se/).

### 4.0.0 (dev)

* Made the library a pure JavaScript library.
* Removed MediaWiki ResourceLoader module definitions.
* Raised DataValues JS library version requirement to 0.10.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already fixed the minor concerns I had with this in 161970d.

@thiemowmde thiemowmde merged commit 0cc36dd into master Oct 9, 2017
@thiemowmde thiemowmde deleted the npm branch October 9, 2017 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants