Lint code using eslint instead of jshint

[manicki]

Task: https://phabricator.wikimedia.org/T165843

[thiemowmde]

Travis still iterates into the node_modules/… directory and complains. Do you know how to fix this?

[manicki]

I have no idea ATM. Didn't happen for me locally, I am not sure what did I mess up.

[Ladsgroup]

It says it can not install eslint now: https://travis-ci.org/wmde/WikibaseDataModelJavaScript/builds/238402279

[manicki]

OK, it was failing because it is build as a PHP project, and PHP VMs have an old node version which is incompatible with eslint version used.
After several attempts I managed to get this work. It is is a bit hacky and rather fragile. OTOH I believe I understand the reason behind distributing a JS library as as package on packagist. Hopefully one day this all will be installed with npm and so on.

[JeroenDeDauw]

distributing a JS library as as package on packagist

The way it's written it's a MW extension, not a JS lib

[manicki]

oh, of course. Silly me.
Then I guess having a PHP build with installing new-enough node is probably the best we can get for now.

[thiemowmde]

Do you think this is fine to be merged as it is now? Looks fine for me. Is there something we can improve about the "fragile" bits you mentioned?

[manicki]

Do you think this is fine to be merged as it is now?

Yes.

Is there something we can improve about the "fragile" bits you mentioned?

Nothing particular I can think of now.