Lint code using eslint instead of jshint (#72)

manicki · manicki · commit 7a3a215ce6f5 · 2017-09-04T10:37:13.000+02:00
Task: https://phabricator.wikimedia.org/T165843
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1,2 @@
+node_modules/**
+vendor/**
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -0,0 +1,27 @@
+{
+	"extends": "wikimedia",
+	"env": {
+		"browser": true,
+		"jquery": true
+	},
+	"globals": {
+		"dataValues": false,
+		"module": "false",
+		"util": false,
+		"wikibase": false
+	},
+	"rules": {
+		"computed-property-spacing": "off",
+		"indent": "off",
+		"keyword-spacing": "off",
+		"no-underscore-dangle": "off",
+		"no-unused-vars": "off",
+		"one-var": "off",
+		"operator-linebreak": "off",
+		"quote-props": "off",
+		"space-before-function-paren": "off",
+		"space-infix-ops": "off",
+		"valid-jsdoc": "off",
+		"vars-on-top": "off"
+	}
+}
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,3 @@
+node_modules/
 vendor/
 .idea/
diff --git a/.jshintignore b/.jshintignore
diff --git a/.jshintrc b/.jshintrc
diff --git a/.travis.yml b/.travis.yml
@@ -5,6 +5,9 @@ php:
 
 sudo: false
 
+before_script:
+  - nvm install 4
+
 script: npm install && npm test
 
 notifications:
diff --git a/package.json b/package.json
@@ -7,7 +7,8 @@
     "jquery": "^3.2.1"
   },
   "devDependencies": {
-    "jshint": "^2.9.4",
+    "eslint": "^3.19.0",
+    "eslint-config-wikimedia": "0.4.0",
     "karma": "^1.7.0",
     "karma-cli": "^1.0.1",
     "karma-phantomjs-launcher": "^1.0.4",
@@ -16,8 +17,8 @@
   },
   "scripts": {
     "postinstall": "composer install",
-    "test": "npm run jshint && npm run run-tests",
-    "jshint": "jshint --show-non-errors --verbose src/ tests/",
+    "test": "npm run eslint && npm run run-tests",
+    "eslint": "eslint .",
     "run-tests": "karma start --single-run"
   }
 }
diff --git a/src/Property.js b/src/Property.js
@@ -103,7 +103,6 @@ var SELF = wb.datamodel.Property = util.inherit(
 	}
 } );
 
-
 /**
  * @inheritdoc
  * @property {string} [TYPE='property']
diff --git a/tests/.eslintrc.json b/tests/.eslintrc.json
@@ -0,0 +1,14 @@
+{
+	"extends": "../.eslintrc.json",
+	"env": {
+		"qunit": true
+	},
+	"globals": {
+		"sinon": false
+	},
+	"rules": {
+		"array-bracket-spacing": "off",
+		"dot-notation": "off",
+		"no-implicit-coercion": "off"
+	}
+}
diff --git a/tests/ClaimList.tests.js b/tests/ClaimList.tests.js
@@ -33,7 +33,7 @@ QUnit.test( 'getPropertyIds()', function( assert ) {
 
 		for( var j = 0; j < testSets[i].length; j++ ) {
 			var propertyId = testSets[i][j].getMainSnak().getPropertyId();
-			if( $.inArray( propertyId , expectedPropertyIds ) === -1 ) {
+			if( $.inArray( propertyId, expectedPropertyIds ) === -1 ) {
 				expectedPropertyIds.push( propertyId );
 			}
 		}
diff --git a/tests/List.tests.js b/tests/List.tests.js
@@ -226,7 +226,7 @@ QUnit.test( 'indexOf()', function( assert ) {
 		list = new wb.datamodel.List( TestItem, items );
 
 	assert.strictEqual(
-		list.indexOf( items [1] ),
+		list.indexOf( items[1] ),
 		1,
 		'Retrieved correct index.'
 	);
diff --git a/tests/SnakList.tests.js b/tests/SnakList.tests.js
@@ -153,7 +153,7 @@ QUnit.test( 'getValidMoveIndices()', function( assert ) {
 	}
 
 	snakList = new wb.datamodel.SnakList(
-		[ new wb.datamodel.PropertyValueSnak( 'P1',  new dv.StringValue( 'a' ) ) ]
+		[ new wb.datamodel.PropertyValueSnak( 'P1', new dv.StringValue( 'a' ) ) ]
 	);
 
 	assert.strictEqual(
diff --git a/tests/StatementList.tests.js b/tests/StatementList.tests.js
@@ -39,7 +39,7 @@ QUnit.test( 'getPropertyIds()', function( assert ) {
 
 		for( var j = 0; j < testSets[i].length; j++ ) {
 			var propertyId = testSets[i][j].getClaim().getMainSnak().getPropertyId();
-			if( $.inArray( propertyId , expectedPropertyIds ) === -1 ) {
+			if( $.inArray( propertyId, expectedPropertyIds ) === -1 ) {
 				expectedPropertyIds.push( propertyId );
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,3 @@`
	`1`	`+node_modules/`
`1`	`2`	`vendor/`
`2`	`3`	`.idea/`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,6 @@ var SELF = wb.datamodel.Property = util.inherit(`
`103`	`103`	`}`
`104`	`104`	`} );`
`105`	`105`
`106`		`-`
`107`	`106`	`/**`
`108`	`107`	`* @inheritdoc`
`109`	`108`	`* @property {string} [TYPE='property']`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ QUnit.test( 'getPropertyIds()', function( assert ) {`
`33`	`33`
`34`	`34`	`for( var j = 0; j < testSets[i].length; j++ ) {`
`35`	`35`	`var propertyId = testSets[i][j].getMainSnak().getPropertyId();`
`36`		`- if( $.inArray( propertyId , expectedPropertyIds ) === -1 ) {`
	`36`	`+ if( $.inArray( propertyId, expectedPropertyIds ) === -1 ) {`
`37`	`37`	`expectedPropertyIds.push( propertyId );`
`38`	`38`	`}`
`39`	`39`	`}`