Skip to content

Fix inconsistency in MINUTES #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2015
Merged

Fix inconsistency in MINUTES #66

merged 1 commit into from
Mar 12, 2015

Conversation

thiemowmde
Copy link
Contributor

  • No other precision is plural.
  • Removed the parseInt because the variable is already int.
  • Reversed the loop. The idea is that the precisions relevant in production are usually at the high end of the array.

Bug: T89243

@thiemowmde thiemowmde added this to the 0.7 milestone Mar 4, 2015
@thiemowmde thiemowmde added the bug label Mar 4, 2015
@tobijat
Copy link
Member

tobijat commented Mar 11, 2015

@adrianheine
Copy link
Contributor

+1 Probably needs a README entry?

@thiemowmde
Copy link
Contributor Author

No, doesn't matter because it's not release yet.

@adrianheine
Copy link
Contributor

We still usually add a README entry in the same patch, don't we?

@thiemowmde
Copy link
Contributor Author

  1. This patch fixes an issue introduced in Removed time.js legacy #61.
  2. Removed time.js legacy #61 is already in the README.
  3. Neither nor is released, so this does not qualify as a change at all.

@adrianheine
Copy link
Contributor

I see, thanks :).

adrianheine added a commit that referenced this pull request Mar 12, 2015
Fix inconsistency in MINUTES
@adrianheine adrianheine merged commit 3b66b2e into master Mar 12, 2015
@adrianheine adrianheine deleted the minutes branch March 12, 2015 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants