Removed time.js legacy #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 kloc less to maintain. +1 :) |
|
Nice. |
| */ | ||
| SELF.CALENDARS = { | ||
| GREGORIAN: { | ||
| text: 'Gregorian', |
There was a problem hiding this comment.
I would have called this "key" and made it lowercase. But I see that this is not new, it was like this before.
This was referenced Mar 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Wikibase switched to back-end parsing a while ago, there is no use in further maintaining the ever broken
time.jscomponent providing front-end parsing and formatting. This pull request integrates all "vital" parts of thetime.jscomponent directly intodataValues.TimeValuethat may be interacted with directly now instead of having to retrieve atime.Timeobject from it first.Note: ValueView needs to be adjusted (change is ready to be submitted).
https://phabricator.wikimedia.org/T89243