Skip to content

Fix test that did not tested much #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2014
Merged

Conversation

thiemowmde
Copy link
Contributor

This test barely tested anything.

  1. The inner loop was just pointless.
  2. Three of the four assertions compared the output from Formatter.PRECISIONTEXT with the output from globeCoordinate.Formatter.prototype.precisionText which is a single line that calls Formatter.PRECISIONTEXT. I really don't think this was intended.

Warning: This conflicts with #40. It may be better to merge #40 first and rebase this.

@JeroenDeDauw
Copy link
Contributor

+1

adrianheine added a commit that referenced this pull request Jun 10, 2014
Fix test that did not tested much
@adrianheine adrianheine merged commit 22e90db into master Jun 10, 2014
@adrianheine adrianheine deleted the geo-formatter-test branch June 10, 2014 16:38
@thiemowmde thiemowmde added this to the 0.6 milestone Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants