Remove list of globe coordinate precisions #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this wait for wikimedia/data-values-value-view#58 being merged? Or does our dependency management take care of this? |
|
Since ValueView uses a stable release of DVJS, this can be merged dependency wise |
| @@ -70,7 +70,7 @@ define( [ | |||
| // Look up precision text: | |||
| if( typeof expected === 'number' ) { | |||
|
|
|||
| $.each( globeCoordinate.GlobeCoordinate.PRECISIONS, function( i, precision ) { | |||
| $.each( [ 0.1, 1 / 360 ], function( i, precision ) { | |||
There was a problem hiding this comment.
This part of the test does not do anything now because these two values are not in the precisions array and the if below always fails.
Suggestion: Change the array to [ 10, 1, 1 / 60, 1 / 3600000 ] for now and we will tackle the rest in #41.
tobijat
added a commit
that referenced
this pull request
Jun 6, 2014
Remove list of globe coordinate precisions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not needed anymore and doesn't make any sense on this level.