Fix/sortable list item fixes #2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
approved these changes
Aug 28, 2022
src/incubator/TextField/types.ts
Outdated
| /** | ||
| * Use react-native-gesture-handler instead of react-native for the base TextInput | ||
| */ | ||
| gestureHandler?: boolean; |
There was a problem hiding this comment.
I would call this useGestureHandler
There was a problem hiding this comment.
That sounds more like useGestureHandlerRootView we have in Modal, I thought this keeps the convention of animated and reanimated, WDYT?
There was a problem hiding this comment.
But animated reanimated are descriptive so it works and gestureHandler is a noun
Maybe call it gestureHandled, but that sounds a little weird.
maybe withGestureHandler.. 🤔
|
@M-i-k-e-l |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue with flaky sorting when dragging fast (see #2118)
Scale both axes and add
scaleto propsIncubator.TextField- support a gesture-handler version (for a draggable input list item).WOAUILIB-2824
Changelog
SortableList - fix issue with flaky sorting when dragging fast + add
scaleto props + support a gesture-handler version inIncubator.TextField