Skip to content

Fix loading local images #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Fix loading local images #4769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/android/app/src/main/java/com/reactnativenavigation/utils/ImageLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,15 @@ public void loadIcons(final Context context, List<String> uris, ImagesLoadingLis
@NonNull
private Drawable getDrawable(Context context, String source) throws IOException {
Drawable drawable;

if (isLocalFile(Uri.parse(source))) {
drawable = loadFile(source);
} else {
drawable = loadResource(source);
if (drawable == null || NavigationApplication.instance.isDebug()) {
if (drawable == null && NavigationApplication.instance.isDebug()) {
drawable = readJsDevImage(context, source);
}
}

if (drawable == null) throw new RuntimeException("Could not load image " + source);
return drawable;
}

Expand Down