Skip to content

Fix loading local images #4769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2019
Merged

Fix loading local images #4769

merged 1 commit into from
Feb 20, 2019

Conversation

@guyca
Copy link
Collaborator

@guyca guyca commented Feb 20, 2019 •
edited
Loading

When loading local image resource (images in Drawable folder), RNN mistakingly tried to load the image as a js asset even if it successfully loaded the local image.

Using locals Drawables:

rightButtons: [
  {
    id: 'btn',
    icon: { uri: 'myImageFromDrawablesFolder' }
  }
]

Related to (possibly fixes) #4751

@guyca
Fix loading local images
c8e6eb0 
When loading local image resource (images in Drawable folder), RNN mistakingly tried to load the image as a js asset even if it successfully loaded the local image.
@guyca guyca merged commit c82bc57 into master Feb 20, 2019
@guyca guyca deleted the fixLocalImage branch February 20, 2019 21:57
@guyca guyca mentioned this pull request Feb 21, 2019
Closed
@charpeni charpeni mentioned this pull request Mar 7, 2019
Closed
vshkl pushed a commit to vshkl/react-native-navigation that referenced this pull request Feb 5, 2020
@guyca @vshkl
Fix loading local images (wix#4769)
479fea5 
When loading local image resource (images in Drawable folder), RNN mistakingly tried to load the image as a js asset even if it successfully loaded the local image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guyca