Updated TypeScript from 4.6.0 to 4.8.2#387
Updated TypeScript from 4.6.0 to 4.8.2#387jonathantneal wants to merge 1 commit intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6600b85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hello! Thank you for this PR. Unfortunately, updating to the latest TypeScript version is not that easy. Some changes to our module resolution cache and our code actions are needed to properly support 4.7. Additionally, our current language services force If you're interested in tackling this, I recommend checking out how Svelte's tools did it. But be aware that we don't do things exactly the same way in the module resolution department |
|
Thanks for the quick review, @Princesseuh. To clarify, would the guidance be to apply similar kinds of changes as sveltejs/language-tools#1526? I want to be sure I’m looking at the right change Svelte made. If you’re not sure, I can ask later this week, too. No rush, and again, thank you for the incredibly fast review. |
Yep! That's the right PR. Additionally, support for group aware organize imports should be considered for full support sveltejs/language-tools#1515 I'm okay with that one being tackled separately if you prefer not to, it's alright. I can tackle it myself låter |
|
#389 makes this PR unnecessary. We'll still need to add support for |
Changes
package.jsonexports are supported.build, I noticed a missing interface forInlayHintsOptions, which was then added with citation from the TypeScript Fourslash suite.Testing
Followed CONTRIBUTING.md.
Docs
dependency update only