(feat) support node16/nodenext#1526
Conversation
|
I tried it in my project where I first saw the bug and it seems to work! |
|
Great to hear that! Was the bug around not respecting the exports map of a package? What I'm still confused about is that I don't seem to get errors from TS about missing file endings (.js) from relative imports |
Yes, that's how I've spotted it. In fact, I have a dependency with broken exports and now svelte-check detects it.
Maybe svelte2tsx has something to do with it? |
|
Mhm we might need to also check the resolution mode, as implemented here TypeStrong/ts-node#1778 and exposed since 4.7 (microsoft/TypeScript#49360). Edit: Yep that fixes the "no errors for missing .js extension" problem. |
#1522
Not sure how to test this, I thought that this would error if I leave out
.jsin imports but that's not the case, so I'm not sure if this is actually working. @jasonlyu123 @JuanM04 do you know more? Edit: Turns out that was an error on our part, we need to pass a new parameter to resolveModuleNames in the TypeScript plugin.@JuanM04 would be great if you could test this out: