Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18nIgnore] Rename entryPoint to entrypoint #5475

Merged
merged 4 commits into from
Dec 5, 2023
Merged

[i18nIgnore] Rename entryPoint to entrypoint #5475

merged 4 commits into from
Dec 5, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 22, 2023

Description (required)

Rename entryPoint to entrypoint for the injectRoute API. This is an Astro 4.0 breaking change.

I did a global find+replace for this.

Related issues & labels (optional)

  • Should we create a new 4.0 label, or a major-release label?

For Astro version: 4.0. See astro PR withastro/astro#9161

@bluwy bluwy added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Nov 22, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 5, 2023 4:54pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 22, 2023
@bluwy bluwy mentioned this pull request Nov 22, 2023
Closed
@bluwy bluwy mentioned this pull request Nov 22, 2023
Merged
sarah11918
sarah11918 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the next release!

@sarah11918
Copy link
Member

Will note: check closer to time in case there have been any new language translations made since the time of this PR that will have the older name

@sarah11918 sarah11918 added the 4.0 label Nov 27, 2023
@sarah11918 sarah11918 changed the title Rename entryPoint to entrypoint [i18nIgnore] Rename entryPoint to entrypoint Dec 2, 2023
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Dec 2, 2023
@sarah11918 sarah11918 merged commit 1d55d83 into main Dec 5, 2023
5 of 6 checks passed
@sarah11918 sarah11918 deleted the entrypoint-4.0 branch December 5, 2023 16:41
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@bluwy @sarah11918 @ematipico
[i18nIgnore] Rename entryPoint to entrypoint (#5475)
17c9977 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
4.0 i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bluwy @sarah11918 @yanthomasdev